src/cmd/gc/select.c - Issue 1871057: code review 1871057: gc: empty select

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/gc/select.c

Issue 1871057: code review 1871057: gc: empty select (Closed)

Patch Set: code review 1871057: gc: empty select Created 14 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/gc/select.c

===================================================================

--- a/src/cmd/gc/select.c

+++ b/src/cmd/gc/select.c

@@ -68,8 +68,6 @@

typechecklist(ncase->nbody, Etop);

}

sel->xoffset = count;

- if(count == 0)

- yyerror("empty select");

lineno = lno;

}

@@ -91,7 +89,7 @@

typecheck(&r, Etop);

init = list(init, r);

- if(sel->list == nil)

+ if(sel->list == nil && sel->xoffset != 0)

fatal("double walkselect"); // already rewrote

// register cases

« no previous file with comments | « no previous file | src/pkg/runtime/chan.c » ('j') | no next file with comments »