Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 187060043: Extends JsonWebSignature to support verification with X.509 certificates. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by wonderfly
Modified:
10 years, 7 months ago
Reviewers:
molnar, jasonmheim
Base URL:
https://code.google.com/p/google-http-java-client/
Visibility:
Public.

Description

Extend JsonWebSignature to support verification with X.509 certificates; JsonWebSignature: add support for using the system default trust manager; Log content encoding at HttpRequest if there's one; Use BufferedOutputStream in GZipEncoding; Add error message to precondition check in setChunkSize; Expose the ability to customize the creation of HttpURLConnection instances for NetHttpTransport;

Patch Set 1 #

Patch Set 2 : Revert change of protobuf version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+754 lines, -24 lines) Patch
M google-http-client/src/main/java/com/google/api/client/http/GZipEncoding.java View 2 chunks +2 lines, -2 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/HttpRequest.java View 1 chunk +7 lines, -0 lines 0 comments Download
A google-http-client/src/main/java/com/google/api/client/http/javanet/ConnectionFactory.java View 1 chunk +21 lines, -0 lines 0 comments Download
A google-http-client/src/main/java/com/google/api/client/http/javanet/DefaultConnectionFactory.java View 1 chunk +33 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/http/javanet/NetHttpTransport.java View 8 chunks +43 lines, -12 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/json/webtoken/JsonWebSignature.java View 6 chunks +141 lines, -5 lines 0 comments Download
A google-http-client/src/main/java/com/google/api/client/testing/json/webtoken/TestCertificates.java View 1 chunk +316 lines, -0 lines 0 comments Download
A google-http-client/src/main/java/com/google/api/client/testing/json/webtoken/package-info.java View 1 chunk +22 lines, -0 lines 0 comments Download
M google-http-client/src/main/java/com/google/api/client/util/SecurityUtils.java View 3 chunks +53 lines, -0 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/HttpRequestTest.java View 1 chunk +29 lines, -0 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/http/UrlEncodedContentTest.java View 2 chunks +2 lines, -1 line 0 comments Download
M google-http-client/src/test/java/com/google/api/client/json/webtoken/JsonWebSignatureTest.java View 2 chunks +20 lines, -0 lines 0 comments Download
M google-http-client/src/test/java/com/google/api/client/util/DataTest.java View 1 chunk +1 line, -1 line 0 comments Download
M google-http-client/src/test/java/com/google/api/client/util/SecurityUtilsTest.java View 3 chunks +64 lines, -3 lines 0 comments Download

Messages

Total messages: 5
wonderfly
10 years, 8 months ago (2014-12-10 19:33:57 UTC) #1
wonderfly
Ping.
10 years, 7 months ago (2015-01-06 23:53:48 UTC) #2
jasonmheim
This looks fine to me, but I've never done a review in Reitveld before - ...
10 years, 7 months ago (2015-01-07 13:13:22 UTC) #3
jasonmheim
LGTM
10 years, 7 months ago (2015-01-07 17:29:06 UTC) #4
molnar
10 years, 7 months ago (2015-01-07 17:39:53 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b