Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(261)

Issue 1869054: LTE module for ns-3

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 9 months ago by GiuseppePiro
Modified:
10 years, 9 months ago
Reviewers:
Tom Henderson
CC:
ns-3-reviews_googlegroups.com, Tom Henderson, Nicola Baldo, g.piro_poliba.it, mmiozzo_cttc.es, nbaldo_cttc.es
Visibility:
Public.

Patch Set 1 #

Total comments: 10
Unified diffs Side-by-side diffs Delta from patch set Stats (+13720 lines, -9 lines) Patch
A examples/lte/lte-amc.cc View 1 chunk +219 lines, -0 lines 0 comments Download
A examples/lte/lte-channel-model.cc View 1 chunk +166 lines, -0 lines 0 comments Download
A examples/lte/lte-device.cc View 1 chunk +163 lines, -0 lines 0 comments Download
A examples/lte/lte-phy-downlink.cc View 1 chunk +176 lines, -0 lines 0 comments Download
A examples/lte/lte-phy-uplink.cc View 1 chunk +172 lines, -0 lines 0 comments Download
A examples/lte/waf View 1 chunk +1 line, -0 lines 0 comments Download
A examples/lte/wscript View 1 chunk +23 lines, -0 lines 0 comments Download
M examples/spectrum/waf View 0 chunks +-1 lines, --1 lines 0 comments Download
A src/devices/lte/.lte-propagation-loss-model.cc.swp View Binary file 0 comments Download
A src/devices/lte/AUTHORS View 1 chunk +9 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v0_M10.h View 1 chunk +34 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v0_M12.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v0_M6.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v0_M8.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v120_M10.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v120_M12.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v120_M6.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v120_M8.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v30_M10.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v30_M12.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v30_M6.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v30_M8.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v3_M10.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v3_M12.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v3_M6.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/JakesTraces/multipath_v3_M8.h View 1 chunk +33 lines, -0 lines 0 comments Download
A src/devices/lte/amc-module.h View 1 chunk +93 lines, -0 lines 0 comments Download
A src/devices/lte/amc-module.cc View 1 chunk +199 lines, -0 lines 0 comments Download
A src/devices/lte/bearer-qos-parameters.h View 1 chunk +182 lines, -0 lines 0 comments Download
A src/devices/lte/bearer-qos-parameters.cc View 1 chunk +170 lines, -0 lines 0 comments Download
A src/devices/lte/channel-realization.h View 1 chunk +76 lines, -0 lines 0 comments Download
A src/devices/lte/channel-realization.cc View 1 chunk +122 lines, -0 lines 0 comments Download
A src/devices/lte/enb-lte-spectrum-phy.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/devices/lte/enb-lte-spectrum-phy.cc View 1 chunk +95 lines, -0 lines 0 comments Download
A src/devices/lte/enb-mac-entity.h View 1 chunk +88 lines, -0 lines 0 comments Download
A src/devices/lte/enb-mac-entity.cc View 1 chunk +144 lines, -0 lines 0 comments Download
A src/devices/lte/enb-net-device.h View 1 chunk +125 lines, -0 lines 0 comments Download
A src/devices/lte/enb-net-device.cc View 1 chunk +215 lines, -0 lines 0 comments Download
A src/devices/lte/enb-phy.h View 1 chunk +83 lines, -0 lines 0 comments Download
A src/devices/lte/enb-phy.cc View 1 chunk +208 lines, -0 lines 0 comments Download
A src/devices/lte/ideal-control-messages.h View 1 chunk +217 lines, -0 lines 0 comments Download
A src/devices/lte/ideal-control-messages.cc View 1 chunk +188 lines, -0 lines 0 comments Download
A src/devices/lte/ip-classifier.h View 1 chunk +63 lines, -0 lines 0 comments Download
A src/devices/lte/ip-classifier.cc View 1 chunk +82 lines, -0 lines 0 comments Download
A src/devices/lte/ip-classifier-record.h View 1 chunk +131 lines, -0 lines 0 comments Download
A src/devices/lte/ip-classifier-record.cc View 1 chunk +205 lines, -0 lines 0 comments Download
A src/devices/lte/loss-model.h View 1 chunk +94 lines, -0 lines 0 comments Download
A src/devices/lte/loss-model.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A src/devices/lte/lte-bearer-test.cc View 1 chunk +123 lines, -0 lines 0 comments Download
A src/devices/lte/lte-device-test.cc View 1 chunk +199 lines, -0 lines 0 comments Download
A src/devices/lte/lte-mac-header.h View 1 chunk +55 lines, -0 lines 0 comments Download
A src/devices/lte/lte-mac-header.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/devices/lte/lte-mac-queue.h View 1 chunk +147 lines, -0 lines 0 comments Download
A src/devices/lte/lte-mac-queue.cc View 1 chunk +247 lines, -0 lines 0 comments Download
A src/devices/lte/lte-net-device.h View 1 chunk +213 lines, -0 lines 0 comments Download
A src/devices/lte/lte-net-device.cc View 1 chunk +452 lines, -0 lines 0 comments Download
A src/devices/lte/lte-phy.h View 1 chunk +225 lines, -0 lines 0 comments Download
A src/devices/lte/lte-phy.cc View 1 chunk +263 lines, -0 lines 0 comments Download
A src/devices/lte/lte-phy-test.cc View 1 chunk +189 lines, -0 lines 0 comments Download
A src/devices/lte/lte-propagation-loss-model.h View 1 chunk +77 lines, -0 lines 0 comments Download
A src/devices/lte/lte-propagation-loss-model.cc View 1 chunk +157 lines, -0 lines 0 comments Download
A src/devices/lte/lte-propagation-loss-model-test.cc View 1 chunk +233 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-error-model.h View 1 chunk +72 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-error-model.cc View 1 chunk +72 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-phy.h View 1 chunk +206 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-phy.cc View 1 chunk +500 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-value-helper.h View 1 chunk +75 lines, -0 lines 0 comments Download
A src/devices/lte/lte-spectrum-value-helper.cc View 1 chunk +152 lines, -0 lines 0 comments Download
A src/devices/lte/mac-entity.h View 1 chunk +67 lines, -0 lines 0 comments Download
A src/devices/lte/mac-entity.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A src/devices/lte/multipath.h View 1 chunk +47 lines, -0 lines 0 comments Download
A src/devices/lte/multipath-loss-model.h View 1 chunk +77 lines, -0 lines 0 comments Download
A src/devices/lte/multipath-loss-model.cc View 1 chunk +326 lines, -0 lines 0 comments Download
A src/devices/lte/packet-scheduler.h View 1 chunk +75 lines, -0 lines 0 comments Download
A src/devices/lte/packet-scheduler.cc View 1 chunk +112 lines, -0 lines 0 comments Download
A src/devices/lte/path-loss-model.h View 1 chunk +65 lines, -0 lines 0 comments Download
A src/devices/lte/path-loss-model.cc View 1 chunk +86 lines, -0 lines 0 comments Download
A src/devices/lte/penetration-loss-model.h View 1 chunk +60 lines, -0 lines 0 comments Download
A src/devices/lte/penetration-loss-model.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A src/devices/lte/qos-parameters.h View 1 chunk +162 lines, -0 lines 0 comments Download
A src/devices/lte/qos-parameters.cc View 1 chunk +156 lines, -0 lines 0 comments Download
A src/devices/lte/radio-bearer-instance.h View 1 chunk +151 lines, -0 lines 0 comments Download
A src/devices/lte/radio-bearer-instance.cc View 1 chunk +172 lines, -0 lines 0 comments Download
A src/devices/lte/rlc-entity.h View 1 chunk +61 lines, -0 lines 0 comments Download
A src/devices/lte/rlc-entity.cc View 1 chunk +92 lines, -0 lines 0 comments Download
A src/devices/lte/rrc-entity.h View 1 chunk +112 lines, -0 lines 0 comments Download
A src/devices/lte/rrc-entity.cc View 1 chunk +119 lines, -0 lines 0 comments Download
A src/devices/lte/shadowing-loss-model.h View 1 chunk +71 lines, -0 lines 0 comments Download
A src/devices/lte/shadowing-loss-model.cc View 1 chunk +89 lines, -0 lines 0 comments Download
A src/devices/lte/simple-packet-scheduler.h View 1 chunk +58 lines, -0 lines 0 comments Download
A src/devices/lte/simple-packet-scheduler.cc View 1 chunk +151 lines, -0 lines 0 comments Download
A src/devices/lte/ue-lte-spectrum-phy.h View 1 chunk +56 lines, -0 lines 0 comments Download
A src/devices/lte/ue-lte-spectrum-phy.cc View 1 chunk +139 lines, -0 lines 0 comments Download
A src/devices/lte/ue-mac-entity.h View 1 chunk +48 lines, -0 lines 0 comments Download
A src/devices/lte/ue-mac-entity.cc View 1 chunk +55 lines, -0 lines 0 comments Download
A src/devices/lte/ue-manager.h View 1 chunk +100 lines, -0 lines 0 comments Download
A src/devices/lte/ue-manager.cc View 1 chunk +174 lines, -0 lines 0 comments Download
A src/devices/lte/ue-net-device.h View 1 chunk +125 lines, -0 lines 0 comments Download
A src/devices/lte/ue-net-device.cc View 1 chunk +226 lines, -0 lines 0 comments Download
A src/devices/lte/ue-phy.h View 1 chunk +78 lines, -0 lines 0 comments Download
A src/devices/lte/ue-phy.cc View 1 chunk +242 lines, -0 lines 0 comments Download
A src/devices/lte/ue-record.h View 1 chunk +113 lines, -0 lines 0 comments Download
A src/devices/lte/ue-record.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A src/devices/lte/wscript View 1 chunk +88 lines, -0 lines 0 comments Download
M src/devices/spectrum/multi-model-spectrum-channel.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/devices/spectrum/multi-model-spectrum-channel.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/devices/spectrum/single-model-spectrum-channel.h View 2 chunks +1 line, -1 line 0 comments Download
M src/devices/spectrum/single-model-spectrum-channel.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M src/devices/spectrum/spectrum-interference.h View 2 chunks +1 line, -1 line 0 comments Download
M src/devices/spectrum/spectrum-interference.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A src/devices/wifi/spectrum-yans-wifi-phy.h View 1 chunk +166 lines, -0 lines 0 comments Download
A src/devices/wifi/spectrum-yans-wifi-phy.cc View 1 chunk +615 lines, -0 lines 0 comments Download
A src/devices/wifi/wifi-phy-tag.h View 1 chunk +60 lines, -0 lines 0 comments Download
A src/devices/wifi/wifi-phy-tag.cc View 1 chunk +100 lines, -0 lines 0 comments Download
A src/devices/wifi/wifi-spectrum-phy-interface.h View 1 chunk +52 lines, -0 lines 0 comments Download
A src/devices/wifi/wifi-spectrum-phy-interface.cc View 1 chunk +70 lines, -0 lines 0 comments Download
A src/helper/lte-helper.h View 1 chunk +132 lines, -0 lines 10 comments Download
A src/helper/lte-helper.cc View 1 chunk +323 lines, -0 lines 0 comments Download
M src/helper/wscript View 2 chunks +2 lines, -0 lines 0 comments Download
M src/node/spectrum-channel.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/wscript View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
Tom Henderson
Giuseppe, here is an initial review on a few files. It will take some time ...
10 years, 9 months ago (2010-08-09 05:47:59 UTC) #1
GiuseppePiro
10 years, 9 months ago (2010-08-12 13:58:31 UTC) #2
Hi Tom, 
I fixed some things that you have suggested for the first review.

These tasks have been addressed:
- completed the doxygen documentation for the LTE module (now there are no
warnings with ./waf doxigen | grep lte)
- improved logging function 
- fixed some problems on lte-helper class

I'm waiting for other your opinions.

Best Regards

Giuseppe Piro

http://codereview.appspot.com/1869054/diff/1/119
File src/helper/lte-helper.h (right):

http://codereview.appspot.com/1869054/diff/1/119#newcode32
src/helper/lte-helper.h:32: #include "ns3/deprecated.h"
On 2010/08/09 05:47:59, Tom Henderson wrote:
> why is this needed (deprecated.h)?

The library has been deleted!

http://codereview.appspot.com/1869054/diff/1/119#newcode34
src/helper/lte-helper.h:34: //#include "ns3/lte-spectrum-channel.h"
On 2010/08/09 05:47:59, Tom Henderson wrote:
> delete if not needed

Done.

http://codereview.appspot.com/1869054/diff/1/119#newcode52
src/helper/lte-helper.h:52: class LteHelper //:public PcapHelperForDevice,
public AsciiTraceHelperForDevice
On 2010/08/09 05:47:59, Tom Henderson wrote:
> Are you going to support tracing here or not?  (commented out)

Actually the tracing is not supported. I will plan its implementation in the
future.

http://codereview.appspot.com/1869054/diff/1/119#newcode123
src/helper/lte-helper.h:123: Ptr<LtePhy> phy);
On 2010/08/09 05:47:59, Tom Henderson wrote:
> missing doxygen on this function

Done.

http://codereview.appspot.com/1869054/diff/1/119#newcode127
src/helper/lte-helper.h:127: Ptr<SingleModelSpectrumChannel> m_uplinkChannel;
On 2010/08/09 05:47:59, Tom Henderson wrote:
> Typically we do not expose raw pointers in our public APIs.

Both pointers have been defined as private members.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b