Converting modules/timesheet to use tryton Transaction module

[ced, 2010-07-29 20:18:32]

You should also update INSTALL to require Python 2.5

http://codereview.appspot.com/1869048/diff/1003/2001
File line.py (right):

http://codereview.appspot.com/1869048/diff/1003/2001#newcode40
line.py:40: user = user_obj.browse(user_id)
user_id -> Transaction().user

http://codereview.appspot.com/1869048/diff/1003/2001#newcode52
line.py:52: return date_obj.today()
Could be written in one line:
return Transaction().context.get('date') or date_obj.today()

http://codereview.appspot.com/1869048/diff/1003/2001#newcode201
line.py:201: 'act_hours_employee_form')
I think there is tabs here.

http://codereview.appspot.com/1869048/diff/1003/2002
File work.py (right):

http://codereview.appspot.com/1869048/diff/1003/2002#newcode3
work.py:3: "Work"
You can remove this line. It is part of the cleaning.

http://codereview.appspot.com/1869048/diff/1003/2002#newcode46
work.py:46: if Transaction().context.get('company'):
Could be written in one line

http://codereview.appspot.com/1869048/diff/1003/2002#newcode73
work.py:73: all_ids = self.search([('parent', 'child_of', ids)])
Keep the search clause in multi-line.
It is a convention in Tryton that will allow more readable patch later.

http://codereview.appspot.com/1869048/diff/1003/2002#newcode91
work.py:91: hours_by_wt = dict([(i[0], i[1]) for i in
Transaction().cursor.fetchall()])
more then 80 cols

http://codereview.appspot.com/1869048/diff/1003/2002#newcode120
work.py:120: self.write(child_ids, {'active': False})
Same as for search

[ced, 2010-07-30 18:05:06]

http://codereview.appspot.com/1869048/diff/7001/2004
File line.py (right):

http://codereview.appspot.com/1869048/diff/7001/2004#newcode50
line.py:50: return Transaction().context.get['date'] or date_obj.today()
get is a function

http://codereview.appspot.com/1869048/diff/7001/2004#newcode199
line.py:199: 'act_hours_employee_form')
Wrong indentation

http://codereview.appspot.com/1869048/diff/7001/2005
File work.py (right):

http://codereview.appspot.com/1869048/diff/7001/2005#newcode45
work.py:45: return Transaction().context.get['company'] or False
get is a function

http://codereview.appspot.com/1869048/diff/7001/2005#newcode91
work.py:91: [(i[0], i[1]) for i in Transaction().cursor.fetchall()]
It will be better to use iterators instead of list

[ced, 2010-07-30 19:42:55]

http://codereview.appspot.com/1869048/diff/12001/13003
File work.py (right):

http://codereview.appspot.com/1869048/diff/12001/13003#newcode92
work.py:92: hours_by_wt[i[0]] = i[1]
I did not mean that. It is:

dict((i[0], i[1]) for i in Transaction().cursor.fetchall())

[ced, 2010-07-31 20:12:16]

http://codereview.appspot.com/1869048/diff/18001/8003
File line.py (right):

http://codereview.appspot.com/1869048/diff/18001/8003#newcode108
line.py:108: act_window_id = model_data_obj.get_id('timesheet','act_line_form')
missing space after ,

http://codereview.appspot.com/1869048/diff/18001/8004
File work.py (right):

http://codereview.appspot.com/1869048/diff/18001/8004#newcode117
work.py:117: child_ids = self.search([('parent', 'child_of', ids)])
multi-line

http://codereview.appspot.com/1869048/diff/18001/8004#newcode163
work.py:163: act_window_id = model_data_obj.get_id('timesheet','act_work_tree2')
missing space after ,

http://codereview.appspot.com/1869048/diff/18001/8004#newcode180
work.py:180: act_window_id = model_data_obj.get_id('timesheet','act_work_form2')
missing space after ,

http://codereview.appspot.com/1869048/diff/18001/8004#newcode208
work.py:208: act_window_id = model_data_obj.get_id('timesheet','act_work_form3')
missing space after ,

[ced, 2010-08-01 06:49:01]

http://codereview.appspot.com/1869048/diff/23001/3004
File line.py (right):

http://codereview.appspot.com/1869048/diff/23001/3004#newcode3
line.py:3: "Timesheet Line"
Could be removed

[ced, 2010-08-01 20:41:03]

Ok for me