Issue 18670043: Fixed a bug where the vertex data manager was not caching the current value attributes properly.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18670043: Fixed a bug where the vertex data manager was not caching the current value attributes properly. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by Geoff Lang

Modified:
12 years, 5 months ago

Reviewers:
Shannon Woods, Jamie Madill

CC:
angleproject-review_googlegroups.com

Base URL:
https://code.google.com/p/angleproject/@es3proto

Visibility:
Public.

More Reviews

Description

Fixed a bug where the vertex data manager was not caching the current value attributes properly. ANGLEBUG=489

Patch Set 1 #

Total comments: 2

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	src/libGLESv2/VertexAttribute.h	View		1 chunk	+10 lines, -0 lines	2 comments	Download
	M	src/libGLESv2/renderer/VertexDataManager.cpp	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jamie Madill

https://codereview.appspot.com/18670043/diff/1/src/libGLESv2/VertexAttribute.h File src/libGLESv2/VertexAttribute.h (right): https://codereview.appspot.com/18670043/diff/1/src/libGLESv2/VertexAttribute.h#newcode145 src/libGLESv2/VertexAttribute.h:145: return Type == other.Type && memcmp(FloatValues, other.FloatValues, sizeof(float) * ...

12 years, 5 months ago (2013-10-30 15:36:48 UTC) #2

Shannon Woods

12 years, 5 months ago (2013-10-30 21:45:27 UTC) #3

https://codereview.appspot.com/18670043/diff/1/src/libGLESv2/VertexAttribute.h
File src/libGLESv2/VertexAttribute.h (right):

https://codereview.appspot.com/18670043/diff/1/src/libGLESv2/VertexAttribute....
src/libGLESv2/VertexAttribute.h:145: return Type == other.Type &&
memcmp(FloatValues, other.FloatValues, sizeof(float) * 4) == 0;
On 2013/10/30 15:36:48, Jamie Madill wrote:
> brackets around this, otherwise LGTM!

Yesplz on the brackets. And LGTM too.

Expand All Messages | Collapse All Messages