Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(274)

Issue 1866047: Update calendar_todo module for new Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by timitos
Modified:
15 years, 5 months ago
Reviewers:
ced
Visibility:
Public.

Patch Set 1 #

Total comments: 5

Patch Set 2 : fix comments of cedk #

Patch Set 3 : fix wrong _user #

Total comments: 1

Patch Set 4 : Move __future__ import to correct position #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -414 lines) Patch
M todo.py View 1 2 3 32 chunks +294 lines, -316 lines 0 comments Download
M webdav.py View 7 chunks +69 lines, -98 lines 0 comments Download

Messages

Total messages: 7
timitos
15 years, 6 months ago (2010-08-02 17:37:30 UTC) #1
ced
http://codereview.appspot.com/1866047/diff/1/2 File todo.py (right): http://codereview.appspot.com/1866047/diff/1/2#newcode152 todo.py:152: user_ = user_obj.browse(Transaction().user) Could remove _ http://codereview.appspot.com/1866047/diff/1/2#newcode246 todo.py:246: collection_obj.todo(Transaction().cursor.dbname) ...
15 years, 6 months ago (2010-08-02 17:58:15 UTC) #2
timitos
15 years, 6 months ago (2010-08-02 18:09:15 UTC) #3
ced
Ok for me
15 years, 6 months ago (2010-08-02 18:10:12 UTC) #4
ced
http://codereview.appspot.com/1866047/diff/10001/9002 File todo.py (right): http://codereview.appspot.com/1866047/diff/10001/9002#newcode9 todo.py:9: from __future__ import with_statement __futur__ import must be at ...
15 years, 6 months ago (2010-08-03 10:19:19 UTC) #5
timitos
15 years, 6 months ago (2010-08-03 12:33:19 UTC) #6
ced
15 years, 6 months ago (2010-08-07 07:18:46 UTC) #7
Ok for me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b