Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3064)

Issue 186470043: ComputeCredential - improve logging and throw a better exception (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by peleyal
Modified:
4 years, 11 months ago
Reviewers:
srashid, salrashid123
CC:
google-api-dotnet-client_google.com
Base URL:
https://google-api-dotnet-client.googlecode.com/hg/
Visibility:
Public.

Description

ComputeCredential - improve logging and throw a better exception

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Total comments: 2

Patch Set 4 : minor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3 lines) Patch
M Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs View 1 2 3 2 chunks +20 lines, -3 lines 0 comments Download

Messages

Total messages: 3
peleyal
Hi, small fix as you request. Please make sure that it makes sense, and output ...
4 years, 11 months ago (2014-12-19 03:34:34 UTC) #1
salrashid123
LGTM+Approve w/ minor edit below. I emailed peleyal with verification that the error is caught ...
4 years, 11 months ago (2014-12-19 05:32:05 UTC) #2
peleyal
4 years, 11 months ago (2014-12-19 15:29:31 UTC) #3
Done. committing now :)Thanks!

https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right):

https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:85: var error = "Server response
doesn't contain a TokenErrorResponse JSON object. Status code is: "
On 2014/12/19 05:32:05, salrashid123 wrote:
> suggest changing error text from
> doesn't contain a TokenErrorResponse JSON object
> 
> to
> 
> does not contain a JSON object

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b