Issue 186470043: ComputeCredential - improve logging and throw a better exception

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186470043: ComputeCredential - improve logging and throw a better exception (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 10 months ago by peleyal

Modified:
9 years, 10 months ago

Reviewers:
srashid, salrashid123

CC:
google-api-dotnet-client_google.com

Base URL:
https://google-api-dotnet-client.googlecode.com/hg/

Visibility:
Public.

More Reviews

Description

ComputeCredential - improve logging and throw a better exception

Patch Set 1 #

Patch Set 2 : minor #

Patch Set 3 : minor #

Total comments: 2

Patch Set 4 : minor #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs	View	1 2 3	2 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

peleyal

Hi, small fix as you request. Please make sure that it makes sense, and output ...

9 years, 10 months ago (2014-12-19 03:34:34 UTC) #1

salrashid123

LGTM+Approve w/ minor edit below. I emailed peleyal with verification that the error is caught ...

9 years, 10 months ago (2014-12-19 05:32:05 UTC) #2

peleyal

9 years, 10 months ago (2014-12-19 15:29:31 UTC) #3

Done. committing now :)Thanks!

https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
File Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs (right):

https://codereview.appspot.com/186470043/diff/40001/Src/GoogleApis.Auth/OAuth...
Src/GoogleApis.Auth/OAuth2/ComputeCredential.cs:85: var error = "Server response
doesn't contain a TokenErrorResponse JSON object. Status code is: "
On 2014/12/19 05:32:05, salrashid123 wrote:
> suggest changing error text from
> doesn't contain a TokenErrorResponse JSON object
> 
> to
> 
> does not contain a JSON object

Done.

Expand All Messages | Collapse All Messages