Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(300)

Issue 1864043: Rename SecurityTokenDecoder to SecurityTokenCodec (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 2 months ago by mhermanto
Modified:
15 years, 2 months ago
Reviewers:
Paul Lindner, zhoresh
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

The class is named inappropriately, as it does even do any decoding. It is renamed to codec to capture both encoding/decoding work for gadget security tokens.

Patch Set 1 #

Patch Set 2 : Include UPGRADING #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -814 lines) Patch
UPGRADING View 1 chunk +6 lines, -0 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenCodec.java View 4 chunks +5 lines, -5 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenDecoder.java View 1 chunk +0 lines, -105 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java View 1 chunk +1 line, -1 line 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java View 4 chunks +4 lines, -4 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoder.java View 1 chunk +0 lines, -134 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java View 2 chunks +9 lines, -9 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenDecoder.java View 1 chunk +0 lines, -75 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/SecurityToken.java View 1 chunk +1 line, -1 line 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java View 1 chunk +2 lines, -2 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/SecurityTokenDecoder.java View 1 chunk +0 lines, -54 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/SecurityTokenException.java View 1 chunk +1 line, -1 line 0 comments Download
java/common/src/main/java/org/apache/shindig/auth/UrlParameterAuthenticationHandler.java View 4 chunks +10 lines, -10 lines 0 comments Download
java/common/src/main/java/org/apache/shindig/protocol/DataServiceServletFetcher.java View 2 chunks +2 lines, -2 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodecTest.java View 12 chunks +20 lines, -20 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenDecoderTest.java View 1 chunk +0 lines, -235 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenCodecTest.java View 5 chunks +8 lines, -8 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/auth/DefaultSecurityTokenDecoderTest.java View 1 chunk +0 lines, -111 lines 0 comments Download
java/common/src/test/java/org/apache/shindig/common/testing/FakeGadgetToken.java View 2 chunks +3 lines, -3 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/config/ShindigAuthConfigContributor.java View 2 chunks +3 lines, -3 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java View 3 chunks +5 lines, -5 lines 0 comments Download
java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java View 2 chunks +3 lines, -3 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java View 5 chunks +16 lines, -17 lines 0 comments Download
java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java View 2 chunks +3 lines, -3 lines 0 comments Download
java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6
mhermanto
15 years, 2 months ago (2010-07-21 21:35:39 UTC) #1
zhoresh
LGTM Please also update the UPGRADING file and explain the rename since we might break ...
15 years, 2 months ago (2010-07-22 00:12:15 UTC) #2
Paul Lindner
fine with me. I was just being careful to not cause merge issues by renaming ...
15 years, 2 months ago (2010-07-22 00:20:27 UTC) #3
mhermanto
Include UPGRADING
15 years, 2 months ago (2010-07-22 00:36:19 UTC) #4
mhermanto
On 2010/07/22 00:12:15, zhoresh wrote: > LGTM > > Please also update the UPGRADING file ...
15 years, 2 months ago (2010-07-22 00:37:51 UTC) #5
zhoresh
15 years, 2 months ago (2010-07-22 02:50:01 UTC) #6
Thanks Paul. I was thinking to reuse the old names and create simple derived
classes/interface to make it backward compatible. But I think it won't work due
to the interface.

Submitted r966481
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b