code review 186279: Buffer overflow in 5a/6a/8a

Buffer overflow in 5a/6a/8a

[dpx, 2010-01-22 18:08:40]

Hello rsc (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-22 18:27:07]

Instead of bothering with printing an error,
how about using mal to allocate a big enough buffer?

Russ

[dpx, 2010-01-22 19:28:32]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[rsc1, 2010-01-22 22:14:46]

looks good

http://codereview.appspot.com/186279/diff/15/1015
File src/cmd/5a/lex.c (right):

http://codereview.appspot.com/186279/diff/15/1015#newcode145
src/cmd/5a/lex.c:145: ofile = malloc(strlen(file)+3); // +3 as len could
increase by 2 below
please make the comment

// +3 for .x\0  (x=thechar)

should be alloc, not malloc.

same comment on the other files

[dpx, 2010-01-22 23:35:16]

Hello rsc (cc: golang-dev@googlegroups.com),

Please take another look.

[dpx, 2010-01-23 00:03:16]

Done. thanks!

On 2010/01/22 22:14:46, rsc1 wrote:
> looks good
> 
> http://codereview.appspot.com/186279/diff/15/1015
> File src/cmd/5a/lex.c (right):
> 
> http://codereview.appspot.com/186279/diff/15/1015#newcode145
> src/cmd/5a/lex.c:145: ofile = malloc(strlen(file)+3); // +3 as len could
> increase by 2 below
> please make the comment
> 
> // +3 for .x\0  (x=thechar)
> 
> should be alloc, not malloc.
> 
> same comment on the other files

[rsc, 2010-01-23 00:24:11]

LGTM

but it looks like you need to complete the CLA as described at
http://golang.org/doc/contribute.html#copyright

thanks.

[dpx, 2010-01-23 00:30:50]

I just did the online CLA. Thanks!

On 2010/01/23 00:24:11, rsc wrote:
> LGTM
> 
> but it looks like you need to complete the CLA as described at
> http://golang.org/doc/contribute.html#copyright
> 
> thanks.
>

[rsc, 2010-01-23 00:59:19]

*** Submitted as http://code.google.com/p/go/source/detail?r=8d7b27402e36 ***

5a/6a/8a: avoid fixed-sized file name buffer

R=rsc
CC=golang-dev
http://codereview.appspot.com/186279

Committer: Russ Cox <rsc@golang.org>