Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4)

Issue 186270043: cmd/sockdrawer: a tool for package reorganization.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by adonovan
Modified:
12 hours, 45 minutes ago
Reviewers:
rsc
Visibility:
Public.

Description

cmd/sockdrawer: a tool for package reorganization. See doc.go for documentation. DO NOT SUBMIT

Patch Set 1 #

Patch Set 2 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Patch Set 3 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Patch Set 4 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Total comments: 7

Patch Set 5 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Patch Set 6 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Patch Set 7 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Patch Set 8 : diff -r a81b057fa6e0681031c81674e00ad6bbb9f2e18f https://code.google.com/p/go.tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1962 lines, -0 lines) Patch
A cmd/sockdrawer/cluster.go View 1 2 3 4 5 6 7 1 chunk +162 lines, -0 lines 0 comments Download
A cmd/sockdrawer/doc.go View 1 2 3 4 5 6 7 1 chunk +171 lines, -0 lines 0 comments Download
A cmd/sockdrawer/dot.go View 1 2 3 4 5 6 7 1 chunk +189 lines, -0 lines 0 comments Download
A cmd/sockdrawer/fmt.clusters View 1 2 3 4 5 1 chunk +27 lines, -0 lines 0 comments Download
A cmd/sockdrawer/main.go View 1 2 3 4 5 6 7 1 chunk +186 lines, -0 lines 0 comments Download
A cmd/sockdrawer/nodegraph.go View 1 2 3 4 5 6 7 1 chunk +303 lines, -0 lines 0 comments Download
A cmd/sockdrawer/refactor.go View 1 2 3 4 5 6 7 1 chunk +465 lines, -0 lines 0 comments Download
A cmd/sockdrawer/runtime.clusters View 1 2 3 4 5 6 7 1 chunk +264 lines, -0 lines 0 comments Download
A cmd/sockdrawer/scgraph.go View 1 2 3 4 5 6 7 1 chunk +195 lines, -0 lines 0 comments Download

Messages

Total messages: 5
rsc
a few super minor things jumped out at me as i scrolled through the file ...
10 years, 6 months ago (2014-12-12 19:53:23 UTC) #1
adonovan
https://codereview.appspot.com/186270043/diff/60001/cmd/sockdrawer/main.go File cmd/sockdrawer/main.go (right): https://codereview.appspot.com/186270043/diff/60001/cmd/sockdrawer/main.go#newcode5 cmd/sockdrawer/main.go:5: OVERVIEW On 2014/12/12 19:53:23, rsc wrote: > Godoc will ...
10 years, 6 months ago (2014-12-12 20:13:00 UTC) #2
rsc
https://codereview.appspot.com/186270043/diff/60001/cmd/sockdrawer/main.go File cmd/sockdrawer/main.go (right): https://codereview.appspot.com/186270043/diff/60001/cmd/sockdrawer/main.go#newcode823 cmd/sockdrawer/main.go:823: func recvTypeName(T types.Type) *types.TypeName { On 2014/12/12 20:13:00, adonovan ...
10 years, 6 months ago (2014-12-12 21:00:04 UTC) #3
adonovan
On 2014/12/12 21:00:04, rsc wrote: > I'm happy for you both but it's not idiomatic ...
10 years, 6 months ago (2014-12-12 21:17:18 UTC) #4
adonovan
12 hours, 45 minutes ago (2025-06-24 17:23:30 UTC) #5
I finally got around to finishing this idea. See
https://go-review.googlesource.com/c/tools/+/679815. Enjoy!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b