src/cmd/5g/ggen.c - Issue 186263: code review 186263: eliminate the package global name space assumption in o...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/cmd/5g/ggen.c

Issue 186263: code review 186263: eliminate the package global name space assumption in o... (Closed)

Patch Set: code review 186263: eliminate the package global name space assumption in o... Created 15 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/cmd/5g/ggen.c

===================================================================

--- a/src/cmd/5g/ggen.c

+++ b/src/cmd/5g/ggen.c

@@ -810,7 +810,7 @@

goto no;

if(!n->left->addable)

goto no;

- if(strcmp(n->left->sym->package, "runtime") != 0)

+ if(n->left->sym->pkg != runtimepkg)

goto no;

if(strcmp(n->left->sym->name, "slicearray") == 0)

goto slicearray;

« no previous file with comments | « no previous file | src/cmd/5g/gobj.c » ('j') | no next file with comments »