Add LRU memoization, use it for compiled code

[ced, 2010-01-20 18:57:00]

You can add an entry to the CHANGELOG

http://codereview.appspot.com/186242/diff/1/2
File trytond/tools/misc.py (right):

http://codereview.appspot.com/186242/diff/1/2#newcode519
trytond/tools/misc.py:519: def memoize(maxsize):
Declare the function near Cache instead of between _ALLOWED_CODES and safe_eval

http://codereview.appspot.com/186242/diff/1/2#newcode535
trytond/tools/misc.py:535: :param: maxsize the size of the cache (must be bigger
than 4)
Add an assert in __init__ for maxsize

http://codereview.appspot.com/186242/diff/1/2#newcode544
trytond/tools/misc.py:544: max_pointers = [(i+1) * seg_size for i in xrange(3)]
+ [maxsize]
space around +

http://codereview.appspot.com/186242/diff/1/2#newcode579
trytond/tools/misc.py:579: def compile_source(source):
I think it must be a private function

[ced, 2010-01-20 20:51:37]

http://codereview.appspot.com/186242/diff/5/1003
File trytond/tools/misc.py (right):

http://codereview.appspot.com/186242/diff/5/1003#newcode362
trytond/tools/misc.py:362: assert maxsize >= 4
you can put an error message, it helps to understand the issue

http://codereview.appspot.com/186242/diff/5/1003#newcode370
trytond/tools/misc.py:370: min_pointers = [i * seg_size for i in xrange(4)]
Isn't faster to copy pointers instead of construct a new one?

[ced, 2010-01-20 22:57:51]

Ok for me
Don't forget the CHANGELOG

[yangoon1, 2010-01-20 23:05:43]

http://codereview.appspot.com/186242/diff/5/1003
File trytond/tools/misc.py (right):

http://codereview.appspot.com/186242/diff/5/1003#newcode348
trytond/tools/misc.py:348: The cache keep a list of keys logicaly separated in 4
segment :
The cache keeps a list of keys logicaly separated in 4 segments:

http://codereview.appspot.com/186242/diff/5/1003#newcode353
trytond/tools/misc.py:353: For each segment there is a pointer that loop on it.
loops

http://codereview.appspot.com/186242/diff/5/1003#newcode354
trytond/tools/misc.py:354: When a key is accessed form the cache it is promoted
to the first
from

http://codereview.appspot.com/186242/diff/5/1003#newcode357
trytond/tools/misc.py:357: incremented and so on. A key that is removed out of
the last segment
A key that is removed from the last segment

http://codereview.appspot.com/186242/diff/5/1003#newcode360
trytond/tools/misc.py:360: :param: maxsize the size of the cache (must be bigger
or equal than 4)
must be bigger than or equal 4

[bch, 2010-01-21 09:18:35]

applied