Issue 186208: Don't put many2one in the cache (too slow) and externalize some function result outside the loop

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186208: Don't put many2one in the cache (too slow) and externalize some function result outside the loop (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by ced

Modified:
16 years ago

Reviewers:
bch, h.goebel, yangoon1

Visibility:
Public.

Patch Set 2 : Remove unused code and better iterator naming #

Patch Set 3 : Better line break #

Created: 16 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -27 lines)			Patch
	M	trytond/model/modelsql.py	View	1 2	1 chunk	+14 lines, -27 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

h.goebel

http://codereview.appspot.com/186208/diff/1/2 File trytond/model/modelsql.py (right): http://codereview.appspot.com/186208/diff/1/2#newcode1221 trytond/model/modelsql.py:1221: .setdefault(self._name, set()) putting the ".setdefault" into the next line ...

16 years ago (2010-01-19 10:04:15 UTC) #2

Expand All Messages | Collapse All Messages