Issue 186206: Add cache to reduce_ids

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186206: Add cache to reduce_ids (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years ago by ced

Modified:
16 years ago

Reviewers:
bch, h.goebel, yangoon1

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Created: 16 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -33 lines)			Patch
	M	trytond/tools/misc.py	View		2 chunks	+42 lines, -33 lines	2 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

h.goebel

http://codereview.appspot.com/186206/diff/1/2 File trytond/tools/misc.py (right): http://codereview.appspot.com/186206/diff/1/2#newcode475 trytond/tools/misc.py:475: if not res: Why not just return the result ...

16 years ago (2010-01-19 09:42:56 UTC) #2

ced

This implementation is abandoned. We will propose a new generic one based on heapq.

16 years ago (2010-01-19 10:05:59 UTC) #4

h.goebel

16 years ago (2010-01-19 10:10:06 UTC) #5

On 2010/01/19 10:05:59, ced wrote:
> This implementation is abandoned.

"abandoned"? Do you mean "dependent"?

Expand All Messages | Collapse All Messages