Issue 186180: code review 186180: math: 386 FPU hypot

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186180: code review 186180: math: 386 FPU hypot (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by Charlie Dorian

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

math: 386 FPU hypot Added 386 FPU version of Hypot; modified all_test.go to test Hypot with large arguments. Also edited sqrt.go to remove Sqrt(0) as a special case.

Patch Set 1 #

Patch Set 2 : code review 186180: math: 386 FPU hypot #

Patch Set 3 : code review 186180: math: 386 FPU hypot #

Patch Set 4 : code review 186180: math: 386 FPU hypot #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -4 lines)			Patch
M	src/pkg/math/Makefile	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/pkg/math/all_test.go	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
A	src/pkg/math/hypot_386.s	View	1 2 3	1 chunk	+57 lines, -0 lines	0 comments	Download
A	src/pkg/math/hypot_decl.go	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/pkg/math/sqrt.go	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-16 06:39:51 UTC) #1

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-01-18 03:54:55 UTC) #2

Charlie Dorian

Hello rsc (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-01-26 17:05:00 UTC) #3

rsc

14 years, 3 months ago (2010-01-26 20:53:04 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=8b56223ec98b ***

math: 386 FPU hypot

Added 386 FPU version of Hypot; modified all_test.go to test
Hypot with large arguments.  Also edited sqrt.go to remove
Sqrt(0) as a special case.

R=rsc
CC=golang-dev
http://codereview.appspot.com/186180

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages