Issue 186138: code review 186138: cgo: Only allow numeric / string / character type cons...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186138: code review 186138: cgo: Only allow numeric / string / character type cons... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by dho

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, rsaarelm, golang-dev

Visibility:
Public.

Description

cgo: Only allow numeric / string / character type constants for references to #defined things. Fixes issue 520

Patch Set 1 #

Patch Set 2 : code review 186138: cgo: Only allow numeric / string / character type cons... #

Patch Set 3 : code review 186138: cgo: Only allow numeric / string / character type cons... #

Patch Set 4 : code review 186138: cgo: Only allow numeric / string / character type cons... #

Patch Set 5 : code review 186138: cgo: Only allow numeric / string / character type cons... #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	src/cmd/cgo/gcc.go	View	1 2 3	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

dho

Hello rsc, rsaarelm (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-13 19:48:58 UTC) #1

dho

Hello rsc, rsaarelm (cc: golang-dev@googlegroups.com), Please take another look.

14 years, 3 months ago (2010-01-14 00:27:21 UTC) #3

rsc

14 years, 3 months ago (2010-01-14 00:48:16 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=bcbfbe066b58 ***

cgo: Only allow numeric / string / character type constants for references
to #defined things.

Fixes issue 520.

R=rsc, rsaarelm
CC=golang-dev
http://codereview.appspot.com/186138

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages