Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8)

Issue 186135: Review: message passing of closures, and bug fixes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by larrygritz
Modified:
12 years, 7 months ago
Reviewers:
rene.limberger, ckulla
CC:
dev-osl_imageworks.com
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adam requested that setmessage/getmessage be made to work for closures, which were previously not allowed to be messages. OK, so this does it. Also note opportunistic fixing of two bugs: (1) in typecheck.cpp, compiler was unintentionally disallowing messages that were arrays. (2) in opmessage.cpp:161, subtle bug where Name is uniform, Val is varying, message being retrieved was varying, didn't properly set the 'varying' flag, resulting in only the first point's value being copied to Val properly.

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -21 lines) Patch
M src/doc/languagespec.tex View 2 chunks +3 lines, -3 lines 0 comments Download
M src/include/osl_pvt.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/liboslcomp/typecheck.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/liboslexec/context.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/liboslexec/opmessage.cpp View 8 chunks +58 lines, -16 lines 4 comments Download
M src/liboslexec/oslexec_pvt.h View 2 chunks +5 lines, -0 lines 0 comments Download
M testsuite/message/a.osl View 1 chunk +5 lines, -0 lines 0 comments Download
M testsuite/message/b.osl View 1 chunk +3 lines, -0 lines 0 comments Download
M testsuite/message/ref/out.txt View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 6
rene.limberger
http://codereview.appspot.com/186135/diff/1/6 File src/liboslexec/opmessage.cpp (right): http://codereview.appspot.com/186135/diff/1/6#newcode47 src/liboslexec/opmessage.cpp:47: // don't know anything about them.// for those we ...
12 years, 7 months ago (2010-01-13 18:48:44 UTC) #1
larrygritz
http://codereview.appspot.com/186135/diff/1/6 File src/liboslexec/opmessage.cpp (right): http://codereview.appspot.com/186135/diff/1/6#newcode47 src/liboslexec/opmessage.cpp:47: // don't know anything about them.// for those we ...
12 years, 7 months ago (2010-01-13 19:19:54 UTC) #2
ckulla
http://codereview.appspot.com/186135/diff/1/6 File src/liboslexec/opmessage.cpp (right): http://codereview.appspot.com/186135/diff/1/6#newcode77 src/liboslexec/opmessage.cpp:77: type = TypeDesc::TypeInt; // Actually store closure indices only ...
12 years, 7 months ago (2010-01-13 19:31:29 UTC) #3
larrygritz
http://codereview.appspot.com/186135/diff/1/6 File src/liboslexec/opmessage.cpp (right): http://codereview.appspot.com/186135/diff/1/6#newcode77 src/liboslexec/opmessage.cpp:77: type = TypeDesc::TypeInt; // Actually store closure indices only ...
12 years, 7 months ago (2010-01-13 19:43:33 UTC) #4
ckulla
LGTM Could you also add a test for the fixed array functionality?
12 years, 7 months ago (2010-01-13 19:47:06 UTC) #5
larrygritz
12 years, 7 months ago (2010-01-13 20:06:17 UTC) #6
On 2010/01/13 19:47:06, ckulla wrote:
> LGTM
> 
> Could you also add a test for the fixed array functionality?

Yes, will do after the commit and release.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b