Issue 1861042: Fix tests that I broke

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1861042: Fix tests that I broke (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by MikeSamuel

Modified:
15 years, 8 months ago

Reviewers:
Jasvir

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

The addition of UriUtil.resolve to ResolveUriStage broke a bunch of tests. It quite correctly points out that test:///myTestName and unknown:///unknown are not useful as base URIs. So I just changed tests to make it not raise UriUtil.normalize's hackles. Submitted @4192

Patch Set 1 #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -70 lines)			Patch
M	src/com/google/caja/lang/css/css-extensions-defs.json	View	4 chunks	+29 lines, -2 lines	0 comments	Download
M	src/com/google/caja/lang/css/css-extensions-whitelist.json	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/com/google/caja/plugin/CssValidator.java	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/com/google/caja/plugin/stages/ResolveUriStage.java	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	src/com/google/caja/plugin/templates/TemplateSanitizer.java	View	3 chunks	+22 lines, -15 lines	0 comments	Download
M	tests/com/google/caja/plugin/CssRewriterTest.java	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/com/google/caja/plugin/CssValidatorTest.java	View	2 chunks	+91 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/plugin/stages/ResolveUriStageTest.java	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/TemplateCompilerTest.java	View	8 chunks	+9 lines, -11 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/TemplateSanitizerTest.java	View	8 chunks	+12 lines, -25 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-dynamic.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-dynamic.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-static.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/plugin/templates/template-compiler-golden1-static.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tests/com/google/caja/reporting/HtmlSnippetProducerTest.java	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/com/google/caja/util/CajaTestCase.java	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Jasvir

LGTM Did tools/myvn submit not run the tests before submitting?

15 years, 8 months ago (2010-07-21 03:22:49 UTC) #2

MikeSamuel

15 years, 8 months ago (2010-07-21 03:24:44 UTC) #3

I thought it broke because Firefox was asking if I wanted to install a
new version of a plugin instead of running DomitaTest so I whacked
that plugin and reran just DomitaTest which worked.

2010/7/20  <jasvir@gmail.com>:
> LGTM
>
> Did tools/myvn submit not run the tests before submitting?
>
> http://codereview.appspot.com/1861042/show
>

Expand All Messages | Collapse All Messages