Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1523)

Issue 186096: Improve search_rec_name to take care of ' / ' for issue1369 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 8 months ago by ced
Modified:
10 years, 8 months ago
Reviewers:
bch, h.goebel, yangoon1
Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add improvement from h.goebel #

Total comments: 2

Patch Set 3 : Shorter code from h.goebel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M category.py View 1 2 3 chunks +30 lines, -1 line 0 comments Download

Messages

Total messages: 13
ced
10 years, 8 months ago (2010-01-12 11:39:23 UTC) #1
h.goebel
http://codereview.appspot.com/186096/diff/1/2 File category.py (right): http://codereview.appspot.com/186096/diff/1/2#newcode67 category.py:67: j = 0 Replace by this. It's shorter and ...
10 years, 8 months ago (2010-01-12 12:11:28 UTC) #2
yangoon1
10 years, 8 months ago (2010-01-12 12:17:11 UTC) #3
ced
http://codereview.appspot.com/186096/diff/1/2 File category.py (right): http://codereview.appspot.com/186096/diff/1/2#newcode67 category.py:67: j = 0 On 2010/01/12 12:11:28, h.goebel wrote: > ...
10 years, 8 months ago (2010-01-12 12:18:53 UTC) #4
h.goebel
On 2010/01/12 12:18:53, ced wrote: > I don't understand. It doesn't do the same. Of ...
10 years, 8 months ago (2010-01-12 13:11:25 UTC) #5
h.goebel
10 years, 8 months ago (2010-01-12 13:12:03 UTC) #6
ced
10 years, 8 months ago (2010-01-12 13:53:02 UTC) #7
h.goebel
http://codereview.appspot.com/186096/diff/9/1003 File category.py (right): http://codereview.appspot.com/186096/diff/9/1003#newcode69 category.py:69: if not field: For the first iteration this condition ...
10 years, 8 months ago (2010-01-12 14:02:08 UTC) #8
ced
http://codereview.appspot.com/186096/diff/9/1003 File category.py (right): http://codereview.appspot.com/186096/diff/9/1003#newcode69 category.py:69: if not field: On 2010/01/12 14:02:08, h.goebel wrote: > ...
10 years, 8 months ago (2010-01-12 14:07:28 UTC) #9
ced
10 years, 8 months ago (2010-01-12 14:07:48 UTC) #10
bch
On 2010/01/12 14:07:48, ced wrote: > OK
10 years, 8 months ago (2010-01-12 18:32:06 UTC) #11
h.goebel
Okay. Tested with several files. Please backport to 1.4, too. Thanks!
10 years, 8 months ago (2010-01-12 22:18:48 UTC) #12
ced
10 years, 8 months ago (2010-01-12 22:37:15 UTC) #13
On 2010/01/12 22:18:48, h.goebel wrote:
> Okay. Tested with several files.
> 
> Please backport to 1.4, too. Thanks!

For me, it is not a bug fix as it change the previous behavior of
search_rec_name and adds a constraint. So it doesn't enter in the release
policy.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b