On 2010/01/12 11:18:11, udo.spallek wrote: > why not use a timestamp as appendix for uniqueness? ...
16 years, 1 month ago
(2010-01-12 11:20:21 UTC)
#3
On 2010/01/12 11:18:11, udo.spallek wrote:
> why not use a timestamp as appendix for uniqueness?
We don't care to be unique. We must avoid to use column name that could come
from a Model.
Ok. Other question: In sqlite/table.py def alter_size(self, column_name, column_type): logging.getLogger('init').warning( 'Unable to alter size of ...
16 years, 1 month ago
(2010-01-12 11:59:20 UTC)
#4
Ok.
Other question:
In sqlite/table.py
def alter_size(self, column_name, column_type):
logging.getLogger('init').warning(
'Unable to alter size of column %s ' \
'of table %s not null!' % \
(column_name, self.table_name))
I don't understand "...not null".
I think it could be deleted.
On 2010/01/12 11:59:20, yangoon wrote: > Ok. > > Other question: > > In sqlite/table.py ...
16 years, 1 month ago
(2010-01-12 12:19:47 UTC)
#5
On 2010/01/12 11:59:20, yangoon wrote:
> Ok.
>
> Other question:
>
> In sqlite/table.py
> def alter_size(self, column_name, column_type):
> logging.getLogger('init').warning(
> 'Unable to alter size of column %s ' \
> 'of table %s not null!' % \
> (column_name, self.table_name))
>
> I don't understand "...not null".
> I think it could be deleted.
Don't it was typo from bad copy/paste.
On 2010/01/12 11:20:21, ced wrote: > On 2010/01/12 11:18:11, udo.spallek wrote: > > why not ...
16 years, 1 month ago
(2010-01-12 12:29:00 UTC)
#6
On 2010/01/12 11:20:21, ced wrote:
> On 2010/01/12 11:18:11, udo.spallek wrote:
> > why not use a timestamp as appendix for uniqueness?
> We don't care to be unique. We must avoid to use column name that could come
> from a Model.
Ok, if it is impossible, that a column name start with an underscore, your
provided patch is ok for me.
Issue 186092: Use column starting with "_" in alter_size to prevent naming collision
(Closed)
Created 16 years, 1 month ago by ced
Modified 16 years ago
Reviewers: bch, udono, yangoon1
Base URL:
Comments: 0