Issue 186077: code review 186077: add pprof output format to prof.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 186077: code review 186077: add pprof output format to prof. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by r

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

add pprof output format to prof. amd64 linux only.

Patch Set 1 #

Patch Set 2 : code review 186077: add pprof output format to prof. #

Patch Set 3 : code review 186077: add pprof output format to prof. #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+280 lines, -19 lines)			Patch
	M	src/cmd/prof/doc.go	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download
	M	src/cmd/prof/main.c	View	1 2	20 chunks	+273 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Hello (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-11 23:34:31 UTC) #1

rsc

LGTM add reference to http://code.google.com/p/google-perftools. (it uses pprof only.)

14 years, 3 months ago (2010-01-11 23:51:31 UTC) #2

14 years, 3 months ago (2010-01-12 00:53:49 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=b6ef2abad26f ***

add pprof output format to prof.
amd64 linux only.

R=rsc
CC=golang-dev
http://codereview.appspot.com/186077

Expand All Messages | Collapse All Messages