Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10)

Issue 1860047: Update project module for new Transaction (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 6 months ago by ced
Modified:
15 years, 5 months ago
Reviewers:
bch, pheller, zodman
CC:
tryton-dev_googlegroups.com
Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add missing import of Transaction #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -39 lines) Patch
M INSTALL View 1 chunk +1 line, -1 line 0 comments Download
M work.py View 1 8 chunks +33 lines, -38 lines 9 comments Download

Messages

Total messages: 7
ced
15 years, 6 months ago (2010-08-05 15:40:04 UTC) #1
pheller
http://codereview.appspot.com/1860047/diff/1/3 File work.py (right): http://codereview.appspot.com/1860047/diff/1/3#newcode117 work.py:117: with Transaction().set_context(active_test=False): need to import Transaction
15 years, 6 months ago (2010-08-09 14:45:22 UTC) #2
ced
15 years, 6 months ago (2010-08-09 14:49:10 UTC) #3
pheller
looks good here
15 years, 6 months ago (2010-08-09 14:55:51 UTC) #4
zodman
i have a bug on project. http://img837.imageshack.us/img837/9944/pantallazofo.png http://codereview.appspot.com/1860047/diff/5001/6002 File work.py (right): http://codereview.appspot.com/1860047/diff/5001/6002#newcode81 work.py:81: if context.get('type') ...
15 years, 5 months ago (2010-08-29 23:40:54 UTC) #5
pheller
Sorry guys, it seems I might have missed a thing or two in Project.... http://codereview.appspot.com/1860047/diff/5001/6002 ...
15 years, 5 months ago (2010-08-30 00:59:35 UTC) #6
ced
15 years, 5 months ago (2010-08-30 05:57:20 UTC) #7
http://codereview.appspot.com/1860047/diff/5001/6002
File work.py (right):

http://codereview.appspot.com/1860047/diff/5001/6002#newcode27
work.py:27: self.parent = copy.copy(self.parent)
On 2010/08/30 00:59:35, pheller wrote:
> ced: Is this needed?  Doesn't this just assign self.parent to a week copy of
> itself?
parent is a class attribute so we must copy it to not change it on all
TimesheetWork instance in every pool.

http://codereview.appspot.com/1860047/diff/5001/6002#newcode29
work.py:29: self.parent.context['type'] = Eval('type')
On 2010/08/30 00:59:35, pheller wrote:
> ??

This is an other context

http://codereview.appspot.com/1860047/diff/5001/6002#newcode81
work.py:81: if context.get('type') == 'project':
On 2010/08/30 00:59:35, pheller wrote:
> On 2010/08/29 23:40:54, zodman wrote:
> > Transaction().context.get('type') ... must be ?
> 
> Yes, right.

Fixed but next time fill an issue in the roundup when the codereview is closed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b