Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(64)

Issue 18600046: Update docs with recent changes for bundle api.

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 5 months ago by rharding
Modified:
11 years, 5 months ago
Reviewers:
bac, mp+193795
Visibility:
Public.

Description

Update docs with recent changes for bundle api. https://code.launchpad.net/~rharding/charmworld/api-docs/+merge/193795 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -0 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M docs/api.rst View 2 chunks +82 lines, -0 lines 3 comments Download

Messages

Total messages: 2
rharding
Please take a look.
11 years, 5 months ago (2013-11-04 15:14:40 UTC) #1
bac
11 years, 5 months ago (2013-11-04 15:22:28 UTC) #2
LGTM.  Thanks.

https://codereview.appspot.com/18600046/diff/1/docs/api.rst
File docs/api.rst (right):

https://codereview.appspot.com/18600046/diff/1/docs/api.rst#newcode474
docs/api.rst:474: A deployer file containing bundles can be checked to verify
that the charms specified in the bundles are in fact valid and found in the
store. It will also check that the configuration options specified match those
from the charms found. Finally, it will also verify that any relations
constructed are also valid for the charms found.
wrap

https://codereview.appspot.com/18600046/diff/1/docs/api.rst#newcode484
docs/api.rst:484: deployer_file='{ "wiki": { "services": { "wiki": { "charm":
"mediawiki", "num_units": 2, "branch": "lp:charms/precise/mediawiki",
"constraints": "mem=2" }, "haproxy": { "options": { "request-limit": 32 },
"branch": "lp:charms/precise/haproxy" }, "db": { "charm": "mysql", "options": {
"tuning-level": "fast" }, "branch": "lp:charms/precise/mysql" }, "memcached": {
"options": { "request-limit": 32 }, "branch": "lp:charms/precise/memcached" } },
"series": "precise", "promulgated": true, "relations": [ [ "wiki:db",
"memcached" ], [ "db", [ "haproxy", "db" ] ] ] } }'
wrap

https://codereview.appspot.com/18600046/diff/1/docs/api.rst#newcode532
docs/api.rst:532: 
Maybe a statement that a 200 does not mean the bundle passes proof and mention
that an empty errors field indicates success.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b