Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
|
Sign in
(1308)
Issues
Repositories
Search
Open Issues
|
Closed Issues
|
All Issues
|
Sign in
with your
Google Account
to create issues and add comments
Issue
185850043
: Fixes ibus_keyval_name method in c++ binding (Closed)
Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by
Peng Wu
Modified:
10 years, 1 month ago
Reviewers:
shawn.p.huang,
fujiwara
,
Peng
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.
More Reviews
Description
Fixes ibus_keyval_name method in c++ binding Add G_BEGIN_DECLS and G_END_DECLS macros in src/ibuskeys.h BUG=
Patch Set 1
#
Created:
10 years, 1 month ago
Download
[raw]
[tar.bz2]
Unified diffs
Side-by-side diffs
Delta from patch set
Stats
(
+2 lines, -0 lines
)
Patch
M
src/ibuskeys.h
View
2 chunks
+2 lines, -0 lines
0 comments
Download
Messages
Total messages: 4
Expand All Messages
|
Collapse All Messages
Peng Wu
Please review it, thanks.
10 years, 1 month ago (2014-12-04 05:58:12 UTC)
#1
Please review it, thanks.
Sign in
to reply to this message.
fujiwara
10 years, 1 month ago (2014-12-04 06:14:24 UTC)
#2
Sign in
to reply to this message.
fujiwara
LGTM
10 years, 1 month ago (2014-12-04 06:29:45 UTC)
#3
LGTM
Sign in
to reply to this message.
Peng
lgtm
10 years, 1 month ago (2014-12-04 14:25:13 UTC)
#4
lgtm
Sign in
to reply to this message.
Expand All Messages
|
Collapse All Messages
Issue 185850043: Fixes ibus_keyval_name method in c++ binding (Closed)
Created 10 years, 1 month ago by Peng Wu
Modified 10 years, 1 month ago
Reviewers: fujiwara, shawn.p.huang_gmail.com
Base URL: git://github.com/ibus/ibus.git@master
Comments: 0
Recent Issues
|
This issue
This is Rietveld
f62528b