IOException on writing to a closed HttpServletResponse

After doing a sendError to a HttpServletResponse, the response is considered to be committed and should not be written to. Trying to do so throws an IOException.

[gagan.goku, 2010-07-15 12:56:22]

On 2010/07/15 11:08:59, kuntal.loya wrote:
> 

Hi Kuntal
I think this patch is not in the format rietveld expects. Please reupload.
The change itself looks fine. Basically your adding the IOUtils.copy line in the
else block of if (results.getHttpStatusCode() != HttpResponse.SC_OK), which is
okay if redirects are being following.
But probably a better refactoring would be :

if (results.isError()) {
  if (results.getHttpStatusCode() == HttpResponse.SC_INTERNAL_SERVER_ERROR) {
    // External "internal error" should be mapped to gateway error
    response.sendError(HttpResponse.SC_BAD_GATEWAY);
  } else {
    response.sendError(results.getHttpStatusCode());
  }
} else {
  IOUtils.copy ...
}

Thoughts ?

[Kuntal Loya, 2010-07-15 13:48:48]

Using isError() to check for error.

[Kuntal Loya, 2010-07-15 13:50:18]

Fixing the patch

[gagan.goku, 2010-07-15 19:13:12]

On 2010/07/15 13:50:18, kuntal.loya wrote:
> Fixing the patch

lgtm :)
Please ask a committer to commit.

[Kuntal Loya, 2010-07-16 06:58:40]

After doing a sendError to a HttpServletResponse, the response is considered to
be committed and should not be written to. Trying to do so throws an
IOException.

[Paul Lindner, 2010-07-16 11:23:42]

seems fine.

[johnfargo, 2010-07-19 17:22:18]

Hi Kuntal:

LGTM as well; committed now since this is an Exception-throwing fix.

This said, I'd love to see a test for this, ensuring that the previously
Exception-throwing condition does not occur. Could you whip one up for me?

Thanks,
John