Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 185420043: Fix compile error on MINGW (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by Tamas Berghammer
Modified:
9 years, 10 months ago
Reviewers:
Billy Donahue
CC:
googletestframework_googlegroups.com
Base URL:
http://googletest.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Fixing compilation issue when compiling gtest-all.cc with MINGW (tested with x86_64-w64-mingw32-g++ (GCC) 4.8.3). MINGW don't support neither localtime_s not localtime_r but localtime is thread safe in this case because on Windows localtime use a single tm structure per thread. (http://msdn.microsoft.com/en-us/library/bf12f0hc.aspx)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M src/gtest.cc View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
Billy Donahue
This is a good patch. I'm going to break out a little bit of separation ...
9 years, 10 months ago (2015-01-05 16:39:42 UTC) #1
Billy Donahue
On 2015/01/05 16:39:42, Billy Donahue wrote: > This is a good patch. I'm going to ...
9 years, 10 months ago (2015-01-05 22:21:38 UTC) #2
Tamas Berghammer
9 years, 10 months ago (2015-01-06 15:44:13 UTC) #3
On 2015/01/05 22:21:38, Billy Donahue wrote:
> On 2015/01/05 16:39:42, Billy Donahue wrote:
> > This is a good patch. I'm going to break out a little bit of separation
> between
> > the Localtime() and the formatting, just to make the portability noise more
> > contained.
> 
> How do you build on mingw? I'd like to verify my own version of this patch
> locally.
> Thanks.

I just building gtest-all.cc and gtest_main.cc with adding the proper include
directories (gtest and gtest/include).
I haven't figured out how to build the tests with mingw yet.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b