Issue 1850049: [Caja] Making Doctype parsing more robust

Issue 1850049: [Caja] Making Doctype parsing more robust (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 11 months ago by gagan.goku

Modified:
15 years, 11 months ago

Reviewers:
MikeSamuel, anupama.dutta, cool-shindig-committers

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

Description

1) Allow no whitespace between public id and system id, like: <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN""http://www.w3.org/TR/html4/loose.dtd"> 2) Allow leading whitespace before DOCTYPE declaration starts, for example: \r\n<!DOCTYPE HTML PUBLIC ...>

Patch Set 1 #

Patch Set 2 : adding_another_test_Case #

Patch Set 3 : adding_another_test_Case #

Patch Set 4 : another_small_fix_in_domparser #

Patch Set 5 : consuming_the_text_token_when_finding_doctype #

Total comments: 4

Patch Set 6 : adding_test_for_domparser_finddoctype #

Patch Set 7 : addressing_comments #

Patch Set 8 : addressing_comments #

Total comments: 2

Patch Set 9 : fixing_test #

Total comments: 2

Patch Set 10 : adding_small_comment_on_test #

Total comments: 1

Created: 15 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -17 lines)			Patch
M	src/com/google/caja/parser/html/DoctypeMaker.java	View	1 2 3 4 5 6	2 chunks	+4 lines, -2 lines	1 comment	Download
M	src/com/google/caja/parser/html/DomParser.java	View	4 5 6	6 chunks	+23 lines, -9 lines	0 comments	Download
M	tests/com/google/caja/parser/html/DoctypeMakerTest.java	View	1 2 3 4 5 6 7 8 9	1 chunk	+14 lines, -0 lines	0 comments	Download
M	tests/com/google/caja/parser/html/DomParserTest.java	View	4 5 6 7 8	3 chunks	+39 lines, -6 lines	0 comments	Download

Messages

Total messages: 9

Expand All Messages | Collapse All Messages

anupama.dutta

http://codereview.appspot.com/1850049/diff/10001/11003 File src/com/google/caja/parser/html/DoctypeMaker.java (right): http://codereview.appspot.com/1850049/diff/10001/11003#newcode93 src/com/google/caja/parser/html/DoctypeMaker.java:93: // XML does not allow the system id to ...

15 years, 11 months ago (2010-08-04 06:13:49 UTC) #1

gagan.goku

15 years, 11 months ago (2010-08-04 06:57:23 UTC) #2

gagan.goku

On 2010/08/04 06:57:23, gagan.goku wrote: > http://codereview.appspot.com/1850049/diff/10001/11003 > File src/com/google/caja/parser/html/DoctypeMaker.java (right): > > http://codereview.appspot.com/1850049/diff/10001/11003#newcode93 > ...

15 years, 11 months ago (2010-08-04 13:00:22 UTC) #3

anupama.dutta

LGTM. Please send to jasvir@ and mikesamuel@ for review. http://codereview.appspot.com/1850049/diff/18001/19001 File tests/com/google/caja/parser/html/DoctypeMakerTest.java (right): http://codereview.appspot.com/1850049/diff/18001/19001#newcode166 tests/com/google/caja/parser/html/DoctypeMakerTest.java:166: ...

15 years, 11 months ago (2010-08-04 14:20:36 UTC) #4

gagan.goku

http://codereview.appspot.com/1850049/diff/18001/19001 File tests/com/google/caja/parser/html/DoctypeMakerTest.java (right): http://codereview.appspot.com/1850049/diff/18001/19001#newcode166 tests/com/google/caja/parser/html/DoctypeMakerTest.java:166: assertDoctype("html", "-//W3C//DTD HTML 4.01 Transitional//EN", On 2010/08/04 14:20:36, anupama.dutta ...

15 years, 11 months ago (2010-08-04 14:47:56 UTC) #5

MikeSamuel

LGTM http://codereview.appspot.com/1850049/diff/22005/27003 File src/com/google/caja/parser/html/DoctypeMaker.java (right): http://codereview.appspot.com/1850049/diff/22005/27003#newcode95 src/com/google/caja/parser/html/DoctypeMaker.java:95: + "(?:" + sStar + "(" + systemLiteral ...

15 years, 11 months ago (2010-08-05 01:50:00 UTC) #6

gagan.goku

Hi Mike Thanks for the review. You will have to commit this change as none ...

15 years, 11 months ago (2010-08-05 09:55:16 UTC) #7

MikeSamuel

Thanks for putting this together. I submitted this patch on your behalf at http://code.google.com/p/google-caja/source/detail?r=4223 Please ...

15 years, 11 months ago (2010-08-06 20:19:53 UTC) #8

gagan.goku

15 years, 11 months ago (2010-08-07 02:58:54 UTC) #9

On 2010/08/06 20:19:53, MikeSamuel wrote:
> Thanks for putting this together.
> 
> I submitted this patch on your behalf at
> http://code.google.com/p/google-caja/source/detail?r=4223
> 
> Please mark this issue closed when you have a chance.

Thanks lots Mike.

Expand All Messages | Collapse All Messages