Issue 1850047: Conversion of modules_party for new Transaction style

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 1850047: Conversion of modules_party for new Transaction style (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 6 months ago by pheller

Modified:
15 years, 6 months ago

Reviewers:
ced

Visibility:
Public.

Patch Set 2 : Fixes per ced's notes #

Total comments: 1

Patch Set 3 : Forgot comma after write args #

Total comments: 1

Patch Set 4 : reverted call to write() with vals dict to multiline #

Created: 15 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+131 lines, -149 lines)			Patch
M	INSTALL	View		1 chunk	+1 line, -1 line	0 comments	Download
M	address.py	View		2 chunks	+12 lines, -14 lines	0 comments	Download
M	category.py	View		3 chunks	+7 lines, -7 lines	0 comments	Download
M	contact_mechanism.py	View	1 2	2 chunks	+24 lines, -32 lines	0 comments	Download
M	party.py	View	1 2 3	8 chunks	+40 lines, -48 lines	0 comments	Download
M	tests/test_party.py	View	1	3 chunks	+47 lines, -47 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

ced

http://codereview.appspot.com/1850047/diff/1/5 File contact_mechanism.py (right): http://codereview.appspot.com/1850047/diff/1/5#newcode94 contact_mechanism.py:94: self.write(ids, {'value': value}) Keep it multi-line http://codereview.appspot.com/1850047/diff/1/6 File party.py ...

15 years, 6 months ago (2010-07-30 16:45:43 UTC) #1

ced

http://codereview.appspot.com/1850047/diff/6001/7004 File contact_mechanism.py (right): http://codereview.appspot.com/1850047/diff/6001/7004#newcode95 contact_mechanism.py:95: 'value': value Put a ending comma

15 years, 6 months ago (2010-07-30 18:01:47 UTC) #3

ced

http://codereview.appspot.com/1850047/diff/13001/14005 File party.py (right): http://codereview.appspot.com/1850047/diff/13001/14005#newcode223 party.py:223: self.write(party.id, {'vat_number': vat_number}) multi-line

15 years, 6 months ago (2010-07-30 18:08:23 UTC) #5

Ok for me

Expand All Messages | Collapse All Messages