Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 184990043: Update cpplint.py to #409 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 11 months ago by avakulenko
Modified:
9 years, 11 months ago
Reviewers:
Elliot Glaysher, keybuk
CC:
Mark Mentovai, erg
Base URL:
http://google-styleguide.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update cpplint.py to #409 409 - Fixed false positive for access-specifier used with virtual in inheritance. 408 - Fixed false positive in determining rvalue parameter types for functions whose return type is on the previous line. 407 - Allow different include sections to be separated by anything other than #include. 406 - Disable readability/streams warnings in cpplint, to reflect style guide changes. 405 - Fixed false positive for whitespace checks with CUDA code. 404 - Do not issue cpplint warnings for use of Doxygen-style comments. 403 - Allow RValue types that were listed in template-argument-list. Fixed handling of RValue types after pointer parameters. 402 - Change the style guide to allow std::forward and associated use of rvalue references. 401 - Fixed cpplint crash when checking header guards for filenames containing meta characters. 400 - Fixed false positive for alignas() used with anonymous struct or union. 399 - Fixed false positive for template function calls with braced constructor. 398 - Allow #endif header guard comments to use "/**/" style if there are no "//" comments in the same file. 397 - Fixed false positives for DISALLOW macro check position check. 396 - Don't treat lambda functions with return value syntax as casts. 395 - <skipped> 394 - Fixed RValue references for out-of-line inner class constructor declarations. 393 - Fixed false positive for redundant override/final by ignoring declarators. 392 - Fixed false positive for taking address of a function pointer return value being recognized as taking address of a cast. 391 - Version of cpplint that fixes the spacing around the '=' operator. 390 - <skipped> 389 - Don't warn on non-const reference arguments of out-of-line method definitions. 388 - Fixed false positive for "virtual" from virtual base class be interpreted as virtual member function. R=erg@google.com Committed: https://code.google.com/p/google-styleguide/source/detail?r=141

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+719 lines, -238 lines) Patch
M cpplint/cpplint.py View 43 chunks +349 lines, -170 lines 0 comments Download
M cpplint/cpplint_unittest.py View 31 chunks +370 lines, -68 lines 0 comments Download

Messages

Total messages: 3
avakulenko
Updated the cpplint.py and unit test to the most recent revision from google3 (r409). All ...
9 years, 11 months ago (2014-12-04 20:59:19 UTC) #1
Elliot Glaysher
lgtm
9 years, 11 months ago (2014-12-04 21:15:57 UTC) #2
avakulenko
9 years, 11 months ago (2014-12-04 22:02:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r141 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b