Issue 184840043: Show language rather than layout in xkb panel icon

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 184840043: Show language rather than layout in xkb panel icon (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 5 months ago by fujiwara

Modified:
9 years, 4 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara, doug_rintoul_sil.org

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Show language rather than layout in xkb panel icon BUG=https://code.google.com/p/ibus/issues/detail?id=1753 TEST=ui/gtk3/ibus-ui-gtk3

Patch Set 2 : Updated with message #2. #

Total comments: 2

Patch Set 3 : Updated with message #4. #

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -28 lines)			Patch
	M	ui/gtk3/panel.vala	View	1 2	1 chunk	+4 lines, -4 lines	0 comments	Download
	M	ui/gtk3/switcher.vala	View	1 2	5 chunks	+18 lines, -24 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/184840043/diff/1/ui/gtk3/switcher.vala File ui/gtk3/switcher.vala (right): https://codereview.appspot.com/184840043/diff/1/ui/gtk3/switcher.vala#newcode432 ui/gtk3/switcher.vala:432: public string get_xkb_symbol(IBus.EngineDesc engine) { get_xkb_symbol should return xkb ...

9 years, 5 months ago (2014-12-04 14:33:01 UTC) #2

fujiwara

9 years, 5 months ago (2014-12-05 07:38:50 UTC) #3

Peng

Lgtm with a comment https://codereview.appspot.com/184840043/diff/20001/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/184840043/diff/20001/ui/gtk3/panel.vala#newcode1143 ui/gtk3/panel.vala:1143: symbol = m_switcher.get_xkb_language(engine); Symbol/language

9 years, 4 months ago (2014-12-06 13:13:05 UTC) #4

fujiwara

9 years, 4 months ago (2014-12-08 03:51:29 UTC) #5

https://codereview.appspot.com/184840043/diff/20001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/184840043/diff/20001/ui/gtk3/panel.vala#newcod...
ui/gtk3/panel.vala:1143: symbol = m_switcher.get_xkb_language(engine);
On 2014/12/06 13:13:05, Peng wrote:
> Symbol/language

Done.

Expand All Messages | Collapse All Messages