Cajole proxied javascript responses with CajaResponseRewriter

Introduce CajaResponseRewriter.java. This rewriter will cajole responses containing javascript if the "cajole" parameter is passed and set to 1.

Example usage:
curl -v "http://localhost:8080/gadgets/concat?container=default&gadget=[insert_gadget_uri]&nocache=1&type=js&1=[insert_js_uri]&cajole=1&nocache=1&debug=1"

Few things left to do:
1) Cajole responses other than javascript.
2) Intelligently detect if the response is javascript instead of depending on the mime type.

[Jasvir, 2010-08-05 23:05:24]

Under what circumstance does CajaResponseRewriter get called?

http://codereview.appspot.com/1847052/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java
(right):

http://codereview.appspot.com/1847052/diff/1/3#newcode120
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java:120:
if (Boolean.TRUE.equals(RewriterUtils.isJavascript(req, resp))) {
Why do this rather than just "if (RewriterUtils.isJavascript(req, resp))"?

[chirag, 2010-08-05 23:33:19]

Depends on the ProxyUriManager.

A ProxyUriManager could be configured to rewrite links through the Shindig proxy
and set the "cajole" query parameter to 1.
 
Once this link is requested, it will be processed by Shindig through a series of
ResponseRewriters including CajaResponseRewriter. 


 

On 2010/08/05 23:05:24, jasvir wrote:
> Under what circumstance does CajaResponseRewriter get called?
> 
> http://codereview.appspot.com/1847052/diff/1/3
> File
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java
> (right):
> 
> http://codereview.appspot.com/1847052/diff/1/3#newcode120
>
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java:120:
> if (Boolean.TRUE.equals(RewriterUtils.isJavascript(req, resp))) {
> Why do this rather than just "if (RewriterUtils.isJavascript(req, resp))"?

[chirag, 2010-08-05 23:33:41]

http://codereview.appspot.com/1847052/diff/1/3
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java
(right):

http://codereview.appspot.com/1847052/diff/1/3#newcode120
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/CajaResponseRewriter.java:120:
if (Boolean.TRUE.equals(RewriterUtils.isJavascript(req, resp))) {
On 2010/08/05 23:05:24, jasvir wrote:
> Why do this rather than just "if (RewriterUtils.isJavascript(req, resp))"?

Done.

[Jasvir, 2010-08-06 21:40:55]

LGTM

[chirag, 2010-08-07 00:19:25]

Committed r983148

On 2010/08/06 21:40:55, jasvir wrote:
> LGTM