Issue 18470043: Set started to true in start()

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18470043: Set started to true in start() (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rafaelw

Modified:
11 years, 6 months ago

Reviewers:
arv

Base URL:
https://github.com/Polymer/observe-js.git@master

Visibility:
Public.

More Reviews

Description

Set started to true in start() TBR=arv Committed: https://github.com/Polymer/observe-js/commit/fb356da

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	src/observe.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

rafaelw

Committed patchset #1 manually as rfb356da (presubmit successful).

11 years, 6 months ago (2013-10-28 16:35:35 UTC) #1

arv

11 years, 6 months ago (2013-10-28 16:49:13 UTC) #2

LGTM


On Mon, Oct 28, 2013 at 12:35 PM, <rafaelw@chromium.org> wrote:

> Reviewers: arv,
>
> Message:
> Committed patchset #1 manually as rfb356da (presubmit successful).
>
> Description:
> Set started to true in start()
>
> TBR=arv
>
> Committed:
https://github.com/Polymer/**observe-js/commit/fb356da<https://github.com/Pol...
>
> Please review this at
https://codereview.appspot.**com/18470043/<https://codereview.appspot.com/184...
>
> Affected files (+1, -0 lines):
>   M src/observe.js
>
>
> Index: src/observe.js
> diff --git a/src/observe.js b/src/observe.js
> index 8f56cda048f769fa0dc3f59b99e56e**fd32f2dec4..**
> de0092f3e2382496d1670426e0c406**6f680b10a9 100644
> --- a/src/observe.js
> +++ b/src/observe.js
> @@ -733,6 +733,7 @@
>      },
>
>      start: function() {
> +      this.started = true;
>        this.connect();
>        this.sync(true);
>      },
>
>
>


-- 
erik

Expand All Messages | Collapse All Messages