Un-break osapi registry mechanism for container mode

Introduced in r965499. Common container, which runs in container mode, will fail to register services (osapi.gadgets.metadata, osapi.gadgets.token) otherwise.

[mhermanto, 2010-07-27 01:42:01]

(+to:randy)

Hi Randy, I'm re-enabling osapi registration for container mode in
jsonrpctransport.js. This is needed for common container.

On Mon, Jul 26, 2010 at 6:32 PM, <mhermanto@gmail.com> wrote:

> Reviewers: ,
>
> Description:
> Introduced in r965499. Common container, which runs in container mode,
> will fail to register services (osapi.gadgets.metadata,
> osapi.gadgets.token) otherwise.
>
> Please review this at http://codereview.appspot.com/1846049/show
>
> Affected files:
>  features/src/main/javascript/features/osapi/jsonrpctransport.js
>
>
> ### Eclipse Workspace Patch 1.0
> #P shindig-project
> Index: features/src/main/javascript/features/osapi/jsonrpctransport.js
> ===================================================================
> --- features/src/main/javascript/features/osapi/jsonrpctransport.js
> (revision 979481)
> +++ features/src/main/javascript/features/osapi/jsonrpctransport.js
> (working copy)
> @@ -88,8 +88,7 @@
>     }
>   }
>
> -  // Do not run this in container mode.
> -  if (gadgets.config && gadgets.config.isGadget) {
> +  if (gadgets.config) {
>     gadgets.config.register("osapi.services", null, init);
>   }
>
>
>
>

[johnfargo, 2010-07-30 00:36:56]

Brief request: please svn up and re-upload the patch -- getting a chunk mismatch
right now.

On 2010/07/27 01:42:01, mhermanto wrote:
> (+to:randy)
> 
> Hi Randy, I'm re-enabling osapi registration for container mode in
> jsonrpctransport.js. This is needed for common container.
> 
> On Mon, Jul 26, 2010 at 6:32 PM, <mailto:mhermanto@gmail.com> wrote:
> 
> > Reviewers: ,
> >
> > Description:
> > Introduced in r965499. Common container, which runs in container mode,
> > will fail to register services (osapi.gadgets.metadata,
> > osapi.gadgets.token) otherwise.
> >
> > Please review this at http://codereview.appspot.com/1846049/show
> >
> > Affected files:
> >  features/src/main/javascript/features/osapi/jsonrpctransport.js
> >
> >
> > ### Eclipse Workspace Patch 1.0
> > #P shindig-project
> > Index: features/src/main/javascript/features/osapi/jsonrpctransport.js
> > ===================================================================
> > --- features/src/main/javascript/features/osapi/jsonrpctransport.js
> > (revision 979481)
> > +++ features/src/main/javascript/features/osapi/jsonrpctransport.js
> > (working copy)
> > @@ -88,8 +88,7 @@
> >     }
> >   }
> >
> > -  // Do not run this in container mode.
> > -  if (gadgets.config && gadgets.config.isGadget) {
> > +  if (gadgets.config) {
> >     gadgets.config.register("osapi.services", null, init);
> >   }
> >
> >
> >
> >
>

[johnfargo, 2010-07-30 00:49:13]

On 2010/07/30 00:36:56, johnfargo wrote:
> Brief request: please svn up and re-upload the patch -- getting a chunk
mismatch
> right now.
> 
> On 2010/07/27 01:42:01, mhermanto wrote:
> > (+to:randy)
> > 
> > Hi Randy, I'm re-enabling osapi registration for container mode in
> > jsonrpctransport.js. This is needed for common container.
> > 
> > On Mon, Jul 26, 2010 at 6:32 PM, <mailto:mhermanto@gmail.com> wrote:
> > 
> > > Reviewers: ,
> > >
> > > Description:
> > > Introduced in r965499. Common container, which runs in container mode,
> > > will fail to register services (osapi.gadgets.metadata,
> > > osapi.gadgets.token) otherwise.
> > >
> > > Please review this at http://codereview.appspot.com/1846049/show
> > >
> > > Affected files:
> > >  features/src/main/javascript/features/osapi/jsonrpctransport.js
> > >
> > >
> > > ### Eclipse Workspace Patch 1.0
> > > #P shindig-project
> > > Index: features/src/main/javascript/features/osapi/jsonrpctransport.js
> > > ===================================================================
> > > --- features/src/main/javascript/features/osapi/jsonrpctransport.js
> > > (revision 979481)
> > > +++ features/src/main/javascript/features/osapi/jsonrpctransport.js
> > > (working copy)
> > > @@ -88,8 +88,7 @@
> > >     }
> > >   }
> > >
> > > -  // Do not run this in container mode.
> > > -  if (gadgets.config && gadgets.config.isGadget) {
> > > +  if (gadgets.config) {
> > >     gadgets.config.register("osapi.services", null, init);
> > >   }
> > >
> > >
> > >
> > >
> >

Actually nm, this is such a small patch I'll just manually merge it.

[johnfargo, 2010-07-30 00:50:10]

Aaaaaand, someone already did this.

On Thu, Jul 29, 2010 at 5:49 PM, <johnfargo@gmail.com> wrote:

> On 2010/07/30 00:36:56, johnfargo wrote:
>
>> Brief request: please svn up and re-upload the patch -- getting a
>>
> chunk mismatch
>
>> right now.
>>
>
>  On 2010/07/27 01:42:01, mhermanto wrote:
>> > (+to:randy)
>> >
>> > Hi Randy, I'm re-enabling osapi registration for container mode in
>> > jsonrpctransport.js. This is needed for common container.
>> >
>> > On Mon, Jul 26, 2010 at 6:32 PM, <mailto:mhermanto@gmail.com> wrote:
>> >
>> > > Reviewers: ,
>> > >
>> > > Description:
>> > > Introduced in r965499. Common container, which runs in container
>>
> mode,
>
>> > > will fail to register services (osapi.gadgets.metadata,
>> > > osapi.gadgets.token) otherwise.
>> > >
>> > > Please review this at http://codereview.appspot.com/1846049/show
>> > >
>> > > Affected files:
>> > >  features/src/main/javascript/features/osapi/jsonrpctransport.js
>> > >
>> > >
>> > > ### Eclipse Workspace Patch 1.0
>> > > #P shindig-project
>> > > Index:
>>
> features/src/main/javascript/features/osapi/jsonrpctransport.js
>
>> > >
>>
> ===================================================================
>
>> > > ---
>>
> features/src/main/javascript/features/osapi/jsonrpctransport.js
>
>> > > (revision 979481)
>> > > +++
>>
> features/src/main/javascript/features/osapi/jsonrpctransport.js
>
>> > > (working copy)
>> > > @@ -88,8 +88,7 @@
>> > >     }
>> > >   }
>> > >
>> > > -  // Do not run this in container mode.
>> > > -  if (gadgets.config && gadgets.config.isGadget) {
>> > > +  if (gadgets.config) {
>> > >     gadgets.config.register("osapi.services", null, init);
>> > >   }
>> > >
>> > >
>> > >
>> > >
>> >
>>
>
> Actually nm, this is such a small patch I'll just manually merge it.
>
>
> http://codereview.appspot.com/1846049/show
>

[mhermanto, 2010-07-30 00:50:13]

Ignore. It looks like it has been removed in trunk. :)

On Thu, Jul 29, 2010 at 5:36 PM, <johnfargo@gmail.com> wrote:

> Brief request: please svn up and re-upload the patch -- getting a chunk
> mismatch right now.
>
>
> On 2010/07/27 01:42:01, mhermanto wrote:
>
>> (+to:randy)
>>
>
>  Hi Randy, I'm re-enabling osapi registration for container mode in
>> jsonrpctransport.js. This is needed for common container.
>>
>
>  On Mon, Jul 26, 2010 at 6:32 PM, <mailto:mhermanto@gmail.com> wrote:
>>
>
>  > Reviewers: ,
>> >
>> > Description:
>> > Introduced in r965499. Common container, which runs in container
>>
> mode,
>
>> > will fail to register services (osapi.gadgets.metadata,
>> > osapi.gadgets.token) otherwise.
>> >
>> > Please review this at http://codereview.appspot.com/1846049/show
>> >
>> > Affected files:
>> >  features/src/main/javascript/features/osapi/jsonrpctransport.js
>> >
>> >
>> > ### Eclipse Workspace Patch 1.0
>> > #P shindig-project
>> > Index:
>>
> features/src/main/javascript/features/osapi/jsonrpctransport.js
>
>> > ===================================================================
>> > --- features/src/main/javascript/features/osapi/jsonrpctransport.js
>> > (revision 979481)
>> > +++ features/src/main/javascript/features/osapi/jsonrpctransport.js
>> > (working copy)
>> > @@ -88,8 +88,7 @@
>> >     }
>> >   }
>> >
>> > -  // Do not run this in container mode.
>> > -  if (gadgets.config && gadgets.config.isGadget) {
>> > +  if (gadgets.config) {
>> >     gadgets.config.register("osapi.services", null, init);
>> >   }
>> >
>> >
>> >
>> >
>>
>
>
>
>
> http://codereview.appspot.com/1846049/show
>