src/pkg/asn1/asn1_test.go - Issue 184080: code review 184080: asn1: fix parsing of elements after a string in a structure.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: src/pkg/asn1/asn1_test.go

Issue 184080: code review 184080: asn1: fix parsing of elements after a string in a structure. (Closed)

Patch Set: code review 184080: asn1: fix parsing of elements after a string in a structure. Created 15 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: src/pkg/asn1/asn1_test.go

===================================================================

--- a/src/pkg/asn1/asn1_test.go

+++ b/src/pkg/asn1/asn1_test.go

@@ -263,6 +263,11 @@

B int

}

+type TestElementsAfterString struct {

+ S string

+ A, B int

var unmarshalTestData []unmarshalTest = []unmarshalTest{

unmarshalTest{[]byte{0x02, 0x01, 0x42}, newInt(0x42)},

unmarshalTest{[]byte{0x30, 0x08, 0x06, 0x06, 0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d}, &TestObjectIdentifierStruct{[]int{1, 2, 840, 113549}}},

@@ -277,6 +282,7 @@

unmarshalTest{[]byte{0x30, 0x08, 0xa1, 0x03, 0x02, 0x01, 0x01, 0x02, 0x01, 0x02}, &TestContextSpecificTags2{1, 2}},

unmarshalTest{[]byte{0x01, 0x01, 0x00}, newBool(false)},

unmarshalTest{[]byte{0x01, 0x01, 0x01}, newBool(true)},

+ unmarshalTest{[]byte{0x30, 0x0b, 0x13, 0x03, 0x66, 0x6f, 0x6f, 0x02, 0x01, 0x22, 0x02, 0x01, 0x33}, &TestElementsAfterString{"foo", 0x22, 0x33}},

}

func TestUnmarshal(t *testing.T) {

« no previous file with comments | « src/pkg/asn1/asn1.go ('k') | no next file » | no next file with comments »