code review 184068: Remove -oldprinter flag from gofmt; all code is

Remove -oldprinter flag from gofmt; all code is
now printed using the semicolon-free style.

Removed NoSemis flag and mechanism dealing with
optional semicolons from go/printer.

Updated all go/printer output files using the
semi-colon free style.

Changes have no formatting impact on checked in
go code under src and misc.

[gri, 2010-01-11 19:25:11]

Hello rsc, r (cc: golang-dev@googlegroups.com),

I'd like you to review this change.

[rsc, 2010-01-11 19:39:25]

LGTM

[r2, 2010-01-11 20:32:20]

LGTM

we should still to be able to parse the old style a little longer.

-rob

[gri, 2010-01-11 20:37:51]

Yes. Parsing is completely decoupled and (unless there are changes to the
AST) we can trivially support both at the moment.
- Robert

On Mon, Jan 11, 2010 at 12:32 PM, Rob 'Commander' Pike <r@google.com> wrote:

> LGTM
>
> we should still to be able to parse the old style a little longer.
>
> -rob
>
>

[gri, 2010-01-11 20:58:15]

*** Submitted as http://code.google.com/p/go/source/detail?r=723a86cf003d ***

Remove -oldprinter flag from gofmt; all code is
now printed using the semicolon-free style.

Removed NoSemis flag and mechanism dealing with
optional semicolons from go/printer.

Updated all go/printer output files using the
semi-colon free style.

Changes have no formatting impact on checked in
go code under src and misc.

R=rsc, r
CC=golang-dev
http://codereview.appspot.com/184068

[cw, 2010-01-11 21:27:40]

Please don't.

It's not entirely clear to me thew old vs new vs whatever syntax issues are all
resolved.

Can't we leave this about for a while longer until there is more of a consensus
there?

[rsc, 2010-01-11 21:32:15]

> It's not entirely clear to me thew old vs new vs whatever syntax issues
> are all resolved.

All the tools now use the new syntax.
If you're using old tools and still need to generate the old
syntax, you can hg update to an earlier tree (I assume that's
how you'd get those tools anyway).  We need to move on:
keeping old code just in case drags everything down.

Russ

[gri, 2010-01-11 21:33:17]

The semicolon-free printing style has been the default for some time now;
except for gofmt, the compilers now accept only the new syntax (gofmt will
continue to accept the old syntax as input for a little longer so that old
programs can be converted). Supporting both styles is adding extra
complexity to gofmt which is not needed anymore.

- Robert



On Mon, Jan 11, 2010 at 1:27 PM, <cw@f00f.org> wrote:

> Please don't.
>
> It's not entirely clear to me thew old vs new vs whatever syntax issues
> are all resolved.
>
> Can't we leave this about for a while longer until there is more of a
> consensus there?
>
>
> http://codereview.appspot.com/184068
>