Issue 184043: code review 184043: runtime: check for preemption due to garbage collection

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 184043: code review 184043: runtime: check for preemption due to garbage collection (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

runtime: check for preemption due to garbage collection in various already expensive routines. helps keep cpu utilization up when GOMAXPROCS > 1, but not a full solution. http://groups.google.com/group/golang-nuts/t/7a9535c4136d3e2

Patch Set 1 #

Patch Set 2 : code review 184043: runtime: check for preemption due to garbage collection #

Patch Set 3 : code review 184043: runtime: check for preemption due to garbage collection #

Patch Set 4 : code review 184043: runtime: check for preemption due to garbage collection #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -2 lines)			Patch
M	src/pkg/runtime/chan.c	View	1 2 3	4 chunks	+12 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/hashmap.c	View	1 2 3	3 chunks	+9 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/malloc.cgo	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/pkg/runtime/mgc0.c	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/pkg/runtime/proc.c	View	1 2	3 chunks	+4 lines, -0 lines	0 comments	Download
M	src/pkg/runtime/runtime.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-08 22:25:42 UTC) #1

LGTM worldstopping makes sense but gcwaiting is more evocative of its purpose. your choice. -rob

14 years, 3 months ago (2010-01-08 23:14:55 UTC) #2

rsc

14 years, 3 months ago (2010-01-09 17:47:47 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=e73e37a4a6da ***

runtime: check for preemption due to garbage collection
	in various already expensive routines.

helps keep cpu utilization up when GOMAXPROCS > 1,
but not a full solution.

http://groups.google.com/group/golang-nuts/t/7a9535c4136d3e2

R=r
CC=golang-dev
http://codereview.appspot.com/184043

Expand All Messages | Collapse All Messages