Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(816)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 183600043: NIX vector routing performance enhancment

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by Steve Smith
Modified:
10 years, 9 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

NIX vector routing performance enhancment

Patch Set 1 #

Total comments: 22

Patch Set 2 : NIX vector routing performance enhancement with review comments fixed" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -16 lines) Patch
M src/nix-vector-routing/model/ipv4-nix-vector-routing.h View 1 2 chunks +23 lines, -8 lines 0 comments Download
M src/nix-vector-routing/model/ipv4-nix-vector-routing.cc View 1 11 chunks +30 lines, -8 lines 0 comments Download

Messages

Total messages: 3
Peter Barnes
https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/ipv4-nix-vector-routing.cc File src/nix-vector-routing/model/ipv4-nix-vector-routing.cc (right): https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/ipv4-nix-vector-routing.cc#newcode91 src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:91: Ipv4NixVectorRouting::FlushGlobalNixRoutingCache () const (void) https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/ipv4-nix-vector-routing.cc#newcode110 src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:110: Ipv4NixVectorRouting::FlushNixCache () const ...
10 years, 10 months ago (2014-12-19 18:49:47 UTC) #1
Tom Henderson
looks fine to me; no further comments beyond Peter's
10 years, 10 months ago (2014-12-19 21:28:52 UTC) #2
Steve Smith
10 years, 9 months ago (2015-01-23 22:10:16 UTC) #3 
Fixed Peter's issues and have pushed updated patch.

Steve

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
File src/nix-vector-routing/model/ipv4-nix-vector-routing.cc (right):

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:91:
Ipv4NixVectorRouting::FlushGlobalNixRoutingCache () const
On 2014/12/19 18:49:47, Peter Barnes wrote:
> (void)

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:110:
Ipv4NixVectorRouting::FlushNixCache () const
On 2014/12/19 18:49:47, Peter Barnes wrote:
> (void)

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:117:
Ipv4NixVectorRouting::FlushIpv4RouteCache () const
On 2014/12/19 18:49:47, Peter Barnes wrote:
> (void)

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:173:
CheckCacheStateAndFlush();
On 2014/12/19 18:49:47, Peter Barnes wrote:
> …Flush ();
>            _ [space]
> 
> And below

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.cc:889:
Ipv4NixVectorRouting::CheckCacheStateAndFlush(void) const
On 2014/12/19 18:49:47, Peter Barnes wrote:
> …Flush (void)
>            _ [space]

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
File src/nix-vector-routing/model/ipv4-nix-vector-routing.h (right):

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:76: * Implementation
note, const is used here due to need to
On 2014/12/19 18:49:47, Peter Barnes wrote:
> \internal
> 
> \c const ...

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:164: * Checks if routing
caches flushes if required.
On 2014/12/19 18:49:47, Peter Barnes wrote:
> What?  Perhaps:
> 
> "Flushes routing cache if required."

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:166: void
CheckCacheStateAndFlush() const;
On 2014/12/19 18:49:47, Peter Barnes wrote:
> void CheckCacheStateAndFlush (void) const;
>                                                _(void) [space and void]
> How about returning bool to indicate a flush occurred?

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:170: * Used for lazy
cleanup of caches when large topology changes.
On 2014/12/19 18:49:47, Peter Barnes wrote:
> "… of caches when there are many topology changes between route requests."

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:174: /* cache stores
nix-vectors based on destination ip */
On 2014/12/19 18:49:47, Peter Barnes wrote:
> /* Cache …

Done.

https://codereview.appspot.com/183600043/diff/1/src/nix-vector-routing/model/...
src/nix-vector-routing/model/ipv4-nix-vector-routing.h:177: /* cache stores
Ipv4Routes based on destination ip */
On 2014/12/19 18:49:47, Peter Barnes wrote:
> /* Cache …

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b