Issue 183157: code review 183157: gc: bug219, bug239, bug240

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183157: code review 183157: gc: bug219, bug239, bug240 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by rsc

Modified:
14 years, 3 months ago

Reviewers:
ken3

CC:
ken2, golang-dev

Visibility:
Public.

Description

gc: bug219, bug239, bug240 Fixes issue 475.

Patch Set 1 #

Patch Set 2 : code review 183157: gc: bug219, bug239, bug240 #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -6 lines)			Patch
M	src/cmd/gc/lex.c	View	1	4 chunks	+22 lines, -6 lines	0 comments	Download
M	test/fixedbugs/bug219.go	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	test/fixedbugs/bug239.go	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
M	test/fixedbugs/bug240.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

rsc

Hello ken2 (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 3 months ago (2010-01-08 07:24:46 UTC) #1

rsc

*** Submitted as http://code.google.com/p/go/source/detail?r=06d2888668e6 *** gc: bug219, bug239, bug240 Fixes issue 475. R=ken2 CC=golang-dev http://codereview.appspot.com/183157

14 years, 3 months ago (2010-01-08 07:24:51 UTC) #2

ken3

14 years, 3 months ago (2010-01-08 07:47:19 UTC) #3

On 2010/01/08 07:24:51, rsc wrote:
> *** Submitted as http://code.google.com/p/go/source/detail?r=06d2888668e6 ***
> 
> gc: bug219, bug239, bug240
> 
> Fixes issue 475.
> 
> R=ken2
> CC=golang-dev
> http://codereview.appspot.com/183157

LGTM

Expand All Messages | Collapse All Messages