Issue 183139: code review 183139: 8g: float->uint64 conversion optimization

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183139: code review 183139: 8g: float->uint64 conversion optimization (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 2 months ago by eds

Modified:
15 years, 2 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

8g: float->uint64 conversion optimization Using FUCOMIP instead of the FUCOMP-FSTSW-SAHF sequence gives better performance and saves code space.

Patch Set 1 #

Patch Set 2 : code review 183139: 8g: float->uint64 conversion optimization #

Created: 15 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	src/cmd/8g/gsubr.c	View		2 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

eds

Hello (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

15 years, 2 months ago (2010-01-07 03:06:13 UTC) #1

rsc

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review this change.

15 years, 2 months ago (2010-01-07 03:28:19 UTC) #3

rsc

15 years, 2 months ago (2010-01-07 03:28:21 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=bd9f50ab63c3 ***

8g: float->uint64 conversion optimization

Using FUCOMIP instead of the FUCOMP-FSTSW-SAHF sequence gives better performance
and saves code space.

R=rsc
CC=golang-dev
http://codereview.appspot.com/183139

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages