Issue 183137: code review 183137: codereview: repeated hg mail sends "PTAL"

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183137: code review 183137: codereview: repeated hg mail sends "PTAL" (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by rsc

Modified:
14 years, 4 months ago

Reviewers:

CC:
r, golang-dev

Visibility:
Public.

Description

codereview: repeated hg mail sends "PTAL" also send out hg mail for TBR submits

Patch Set 2 : code review 183137: codereview: repeated hg mail sends "PTAL" #

Total comments: 1

Patch Set 3 : code review 183137: codereview: repeated hg mail sends "PTAL" #

Created: 14 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -9 lines)			Patch
	M	lib/codereview/codereview.py	View	1 2	7 chunks	+29 lines, -9 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change.

14 years, 4 months ago (2010-01-07 03:28:32 UTC) #1

LGTM http://codereview.appspot.com/183137/diff/1002/1003 File lib/codereview/codereview.py (right): http://codereview.appspot.com/183137/diff/1002/1003#newcode274 lib/codereview/codereview.py:274: pmsg += "PTAL\n" obscure enough to be written ...

14 years, 4 months ago (2010-01-07 04:02:13 UTC) #2

rsc

> obscure enough to be written out, i think. many users are not english speakers ...

14 years, 4 months ago (2010-01-07 17:24:05 UTC) #3

rsc

14 years, 4 months ago (2010-01-08 02:23:32 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=bdc94f4d9c14 ***

codereview: repeated hg mail sends "PTAL"

also send out hg mail for TBR submits

R=r
CC=golang-dev
http://codereview.appspot.com/183137

Expand All Messages | Collapse All Messages