Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(991)

Issue 183121: Naming of tab security and groups (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 10 months ago by yangoon1
Modified:
10 years, 9 months ago
Reviewers:
ced, h.goebel, udono
Visibility:
Public.

Patch Set 1 #

Total comments: 18

Patch Set 2 : Modified proposal without migration code yet #

Total comments: 3

Patch Set 3 : Reverting some items #

Total comments: 2

Patch Set 4 : Users -> Members #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M trytond/res/group.xml View 1 3 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/res/user.xml View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 22
yangoon1
10 years, 10 months ago (2010-01-05 23:57:04 UTC) #1
ced
http://codereview.appspot.com/183121/diff/1/2 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/1/2#newcode25 trytond/res/group.xml:25: <page string="Access Permissions" col="1" id="security"> You should also change ...
10 years, 10 months ago (2010-01-06 09:03:30 UTC) #2
h.goebel
http://codereview.appspot.com/183121/diff/1/2 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/1/2#newcode25 trytond/res/group.xml:25: <page string="Access Permissions" col="1" id="security"> On 2010/01/06 09:03:30, ced ...
10 years, 10 months ago (2010-01-06 10:44:59 UTC) #3
ced
http://codereview.appspot.com/183121/diff/1/2 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/1/2#newcode25 trytond/res/group.xml:25: <page string="Access Permissions" col="1" id="security"> On 2010/01/06 10:44:59, h.goebel ...
10 years, 10 months ago (2010-01-06 10:48:24 UTC) #4
yangoon1
http://codereview.appspot.com/183121/diff/1/2 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/1/2#newcode25 trytond/res/group.xml:25: <page string="Access Permissions" col="1" id="security"> On 2010/01/06 09:03:30, ced ...
10 years, 10 months ago (2010-01-06 13:38:12 UTC) #5
ced
http://codereview.appspot.com/183121/diff/1/2 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/1/2#newcode25 trytond/res/group.xml:25: <page string="Access Permissions" col="1" id="security"> On 2010/01/06 13:38:12, yangoon ...
10 years, 10 months ago (2010-01-06 14:01:30 UTC) #6
yangoon1
I have joined some screenshots to http://bugs.tryton.org/roundup/issue1339 to illustrate the current patch: 1) It shows ...
10 years, 9 months ago (2010-01-09 13:03:07 UTC) #7
h.goebel
On 2010/01/09 13:03:07, yangoon wrote: > I have joined some screenshots to http://bugs.tryton.org/roundup/issue1339 to > ...
10 years, 9 months ago (2010-01-09 21:16:17 UTC) #8
yangoon1
On 2010/01/09 13:03:07, yangoon wrote: > I have joined some screenshots to http://bugs.tryton.org/roundup/issue1339 to > ...
10 years, 9 months ago (2010-01-12 21:20:20 UTC) #9
ced
On 2010/01/12 21:20:20, yangoon wrote: > On 2010/01/09 13:03:07, yangoon wrote: > > I have ...
10 years, 9 months ago (2010-01-12 21:46:43 UTC) #10
h.goebel
cedric.krier@b2ck.com schrieb: >> > 1) It shows 'Group Membership' where the interface is showing the ...
10 years, 9 months ago (2010-01-12 22:05:53 UTC) #11
udono
http://codereview.appspot.com/183121/diff/1/4 File trytond/res/user.py (right): http://codereview.appspot.com/183121/diff/1/4#newcode34 trytond/res/user.py:34: 'uid', 'gid', 'Group Membership') On 2010/01/06 14:01:30, ced wrote: ...
10 years, 9 months ago (2010-01-13 11:31:21 UTC) #12
yangoon1
Please take a look to the second set of screenshots at https://bugs.tryton.org/roundup/issue1339 matching the second ...
10 years, 9 months ago (2010-01-13 13:20:24 UTC) #13
ced
http://codereview.appspot.com/183121/diff/4004/4005 File trytond/res/group.xml (right): http://codereview.appspot.com/183121/diff/4004/4005#newcode21 trytond/res/group.xml:21: <page string="Members" col="2" id="members"> It should be Users http://codereview.appspot.com/183121/diff/4004/4007 ...
10 years, 9 months ago (2010-01-13 13:34:08 UTC) #14
yangoon1
Changed to the wishes of ced. http://codereview.appspot.com/183121/diff/4004/4007 File trytond/res/user.py (right): http://codereview.appspot.com/183121/diff/4004/4007#newcode34 trytond/res/user.py:34: 'uid', 'gid', 'Group ...
10 years, 9 months ago (2010-01-13 17:02:41 UTC) #15
h.goebel
mathias.behrle@gmx.de schrieb: > Once again we are hitting usability questions. > Models are for developers, ...
10 years, 9 months ago (2010-01-13 17:51:35 UTC) #16
yangoon1
On 2010/01/13 13:34:08, ced wrote: > http://codereview.appspot.com/183121/diff/4004/4005 > File trytond/res/group.xml (right): > > http://codereview.appspot.com/183121/diff/4004/4005#newcode21 > ...
10 years, 9 months ago (2010-01-16 10:18:41 UTC) #17
ced
http://codereview.appspot.com/183121/diff/3004/4015 File trytond/res/user.xml (right): http://codereview.appspot.com/183121/diff/3004/4015#newcode79 trytond/res/user.xml:79: <page string="Group Membership" col="1" id="membership"> I don't see the ...
10 years, 9 months ago (2010-01-16 11:04:27 UTC) #18
yangoon1
http://codereview.appspot.com/183121/diff/3004/4015 File trytond/res/user.xml (right): http://codereview.appspot.com/183121/diff/3004/4015#newcode79 trytond/res/user.xml:79: <page string="Group Membership" col="1" id="membership"> On 2010/01/16 11:04:27, ced ...
10 years, 9 months ago (2010-01-16 22:22:00 UTC) #19
ced
On 2010/01/16 22:22:00, yangoon wrote: > http://codereview.appspot.com/183121/diff/3004/4015 > File trytond/res/user.xml (right): > > http://codereview.appspot.com/183121/diff/3004/4015#newcode79 > ...
10 years, 9 months ago (2010-01-16 22:30:53 UTC) #20
yangoon1
10 years, 9 months ago (2010-01-17 12:10:47 UTC) #21
ced
10 years, 9 months ago (2010-01-21 17:29:14 UTC) #22
Ok for me
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b