Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(587)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 183110: Bug fixes and clean up warnings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
16 years ago by Jasvir
Modified:
16 years ago
Reviewers:
Paul Lindner
CC:
shindig.remailer_gmail.com
Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/
Visibility:
Public.

Description

* Fixed bug where & operator used instead of && * added missing hashCode function * closed unclosed i/o streams * removed dead code * removed unnecessary imports Committed @896342.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -125 lines) Patch
M java/common/src/main/java/org/apache/shindig/common/JsonUtil.java View 1 chunk +1 line, -1 line 0 comments Download
M java/common/src/main/java/org/apache/shindig/common/crypto/BasicBlobCrypter.java View 1 chunk +3 lines, -0 lines 0 comments Download
M java/common/src/main/java/org/apache/shindig/config/AbstractContainerConfig.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/common/src/main/java/org/apache/shindig/config/JsonContainerConfig.java View 1 chunk +4 lines, -3 lines 0 comments Download
M java/common/src/main/java/org/apache/shindig/expressions/ShindigTypeConverter.java View 1 chunk +1 line, -1 line 0 comments Download
M java/common/src/main/java/org/apache/shindig/protocol/BaseRequestItem.java View 2 chunks +2 lines, -2 lines 0 comments Download
M java/common/src/main/java/org/apache/shindig/protocol/DefaultHandlerRegistry.java View 2 chunks +2 lines, -2 lines 0 comments Download
M java/common/src/main/java/org/apache/shindig/protocol/conversion/BeanXStreamConverter.java View 1 chunk +1 line, -1 line 0 comments Download
M java/common/src/main/java/org/apache/shindig/protocol/conversion/xstream/GuiceBeanProvider.java View 2 chunks +7 lines, -8 lines 0 comments Download
M java/common/src/test/java/org/apache/shindig/common/crypto/CryptoTest.java View 1 chunk +3 lines, -6 lines 0 comments Download
M java/common/src/test/java/org/apache/shindig/protocol/DataServiceServletTest.java View 2 chunks +9 lines, -12 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/BasicGadgetBlacklist.java View 1 chunk +20 lines, -15 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/encoding/EncodingDetector.java View 2 chunks +1 line, -2 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpRequest.java View 1 chunk +9 lines, -0 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/http/HttpResponse.java View 1 chunk +7 lines, -0 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/oauth/BasicOAuthStore.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/parse/caja/CajaCssParser.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/render/DefaultServiceFetcher.java View 2 chunks +4 lines, -6 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/render/OpenSocialI18NGadgetRewriter.java View 2 chunks +5 lines, -7 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BasicImageRewriter.java View 1 chunk +5 lines, -3 lines 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/CajaContentRewriter.java View 2 chunks +9 lines, -1 line 0 comments Download
M java/gadgets/src/main/java/org/apache/shindig/gadgets/templates/tags/RenderTagHandler.java View 1 chunk +1 line, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/DefaultGadgetSpecFactoryTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/parse/AbstractParsingTestBase.java View 2 chunks +4 lines, -6 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/HttpRequestHandlerTest.java View 2 chunks +5 lines, -6 lines 0 comments Download
M java/gadgets/src/test/java/org/apache/shindig/gadgets/templates/FakeTemplateProcessor.java View 1 chunk +1 line, -1 line 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/core/util/atom/AtomContent.java View 1 chunk +1 line, -1 line 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/Address.java View 1 chunk +5 lines, -6 lines 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EnumUtil.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/PersonHandler.java View 2 chunks +4 lines, -5 lines 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/opensocial/service/SocialRequestItem.java View 2 chunks +4 lines, -6 lines 0 comments Download
M java/social-api/src/main/java/org/apache/shindig/social/opensocial/spi/MessageService.java View 1 chunk +0 lines, -1 line 0 comments Download
M java/social-api/src/test/java/org/apache/shindig/social/SocialApiTestsGuiceModule.java View 2 chunks +3 lines, -9 lines 0 comments Download
M java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/MessageHandlerTest.java View 2 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 1
Paul Lindner
16 years ago (2010-01-05 23:45:58 UTC) #1 
looks great!

commit it!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b