crypto/tls: make Listener a pointer.

crypto/tls: make Listener a pointer.

Listener contains private members and 6g now enforces that private
members cannot be assigned outside of their package.

[gri1, 2009-12-28 19:38:02]

LGTM

On Mon, Dec 28, 2009 at 11:25 AM, <agl@golang.org> wrote:

> Reviewers: rsc,
>
> Description:
> crypto/tls: make Listener a pointer.
>
> Listener contains private members and 6g now enforces that private
> members cannot be assigned outside of their package.
>
> Please review this at http://codereview.appspot.com/183073
>
> Affected files:
>  M src/pkg/crypto/tls/tls.go
>
>
> Index: src/pkg/crypto/tls/tls.go
> ===================================================================
> --- a/src/pkg/crypto/tls/tls.go
> +++ b/src/pkg/crypto/tls/tls.go
> @@ -162,7 +162,7 @@
>        config   *Config
>  }
>
> -func (l Listener) Accept() (c net.Conn, err os.Error) {
> +func (l *Listener) Accept() (c net.Conn, err os.Error) {
>        c, err = l.listener.Accept()
>        if err != nil {
>                return
> @@ -172,13 +172,14 @@
>        return
>  }
>
> -func (l Listener) Close() os.Error { return l.listener.Close() }
> +func (l *Listener) Close() os.Error { return l.listener.Close() }
>
> -func (l Listener) Addr() net.Addr { return l.listener.Addr() }
> +func (l *Listener) Addr() net.Addr { return l.listener.Addr() }
>
>  // NewListener creates a Listener which accepts connections from an inner
>  // Listener and wraps each connection with Server.
> -func NewListener(listener net.Listener, config *Config) (l Listener) {
> +func NewListener(listener net.Listener, config *Config) (l *Listener) {
> +       l = new(Listener)
>        l.listener = listener
>        l.config = config
>        return
>
>
>

[agl1, 2009-12-28 19:40:08]

*** Submitted as http://code.google.com/p/go/source/detail?r=be2470c13c0a ***

crypto/tls: make Listener a pointer.

Listener contains private members and 6g now enforces that private
members cannot be assigned outside of their package.

R=rsc
CC=golang-dev
http://codereview.appspot.com/183073