Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(238)

Issue 183047: code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by eds
Modified:
13 years ago
Reviewers:
CC:
rsc, golang-dev
Visibility:
Public.

Description

8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions Fixes issue 447

Patch Set 1 #

Patch Set 2 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Patch Set 3 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Total comments: 1

Patch Set 4 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/cmd/8a/lex.c View 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/8l/8.out.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/cmd/8l/optab.c View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5
eds
Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.
13 years, 1 month ago (2009-12-24 01:36:15 UTC) #1
rsc
one tiny nit. otherwise looks good. please fix, hg upload, and reply http://codereview.appspot.com/183047/diff/13/16 File src/cmd/8l/optab.c ...
13 years ago (2010-01-05 21:38:24 UTC) #2
eds
PTAL
13 years ago (2010-01-05 23:27:24 UTC) #3
rsc
LGTM thanks
13 years ago (2010-01-06 00:28:34 UTC) #4
rsc
13 years ago (2010-01-06 01:06:43 UTC) #5
*** Submitted as http://code.google.com/p/go/source/detail?r=0c67faa66be7 ***

8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions

Fixes issue 447

R=rsc
CC=golang-dev
http://codereview.appspot.com/183047

Committer: Russ Cox <rsc@golang.org>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b