Issue 183047: code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 183047: code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 4 months ago by eds

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions Fixes issue 447

Patch Set 1 #

Patch Set 2 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Patch Set 3 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Total comments: 1

Patch Set 4 : code review 183047: 8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -1 line)			Patch
M	src/cmd/8a/lex.c	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8l/8.out.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/cmd/8l/optab.c	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

eds

Hello rsc (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

14 years, 4 months ago (2009-12-24 01:36:15 UTC) #1

rsc

one tiny nit. otherwise looks good. please fix, hg upload, and reply http://codereview.appspot.com/183047/diff/13/16 File src/cmd/8l/optab.c ...

14 years, 3 months ago (2010-01-05 21:38:24 UTC) #2

rsc

14 years, 3 months ago (2010-01-06 01:06:43 UTC) #5

*** Submitted as http://code.google.com/p/go/source/detail?r=0c67faa66be7 ***

8a, 8l: Add FCOMI, FCOMIP, FUCOMI, FUCOMIP instructions

Fixes issue 447

R=rsc
CC=golang-dev
http://codereview.appspot.com/183047

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages