Issue 182850043: Use window.onerror for errors in XHR callbacks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 182850043: Use window.onerror for errors in XHR callbacks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 3 months ago by kpreid_google

Modified:
11 years, 3 months ago

Reviewers:
felix8a

CC:
google-caja-discuss_googlegroups.com

Base URL:
http://google-caja.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

If the readystatechange callback of an XHR object throws an error, pass it to window.onerror like for other asynchronous callbacks. Also, extract the repeated pattern of setting up onerror handlers in test-domado-events-guest.html. @r5704

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -18 lines)			Patch
	M	src/com/google/caja/plugin/domado.js	View		3 chunks	+10 lines, -3 lines	0 comments	Download
	M	tests/com/google/caja/plugin/test-domado-events-guest.html	View		5 chunks	+36 lines, -15 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

lgtm

Expand All Messages | Collapse All Messages