Issue 181158: code review 181158: update timing logs for benchmarks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181158: code review 181158: update timing logs for benchmarks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
14 years, 3 months ago by r

Modified:
14 years, 3 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

update timing logs for benchmarks. some significant improvements: reverse-complement nbody (gccgo only) regex-dna pidigits one mysterious drop: binary-tree.go (gccgo only)

Patch Set 1 #

Patch Set 2 : code review 181158: update timing logs for benchmarks. #

Patch Set 3 : code review 181158: update timing logs for benchmarks. #

Patch Set 4 : code review 181158: update timing logs for benchmarks. #

Created: 14 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -0 lines)			Patch
	M	test/bench/timing.log	View	1 2	1 chunk	+84 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Hello (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

14 years, 3 months ago (2010-01-07 00:51:36 UTC) #1

14 years, 3 months ago (2010-01-07 03:36:31 UTC) #3

*** Submitted as http://code.google.com/p/go/source/detail?r=98877e5fdda4 ***

update timing logs for benchmarks.
some significant improvements:
	reverse-complement
	nbody (gccgo only)
	regex-dna
	pidigits
one mysterious drop:
	binary-tree.go (gccgo only)

R=rsc
CC=golang-dev
http://codereview.appspot.com/181158

Expand All Messages | Collapse All Messages