Issue 181080: code review 181080: simplify some code that is using vectors

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 181080: code review 181080: simplify some code that is using vectors (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 3 months ago by gri

Modified:
16 years, 3 months ago

Reviewers:

CC:
agl, agl1, golang-dev

Visibility:
Public.

Description

simplify some code that is using vectors

Patch Set 1 #

Patch Set 2 : code review 181080: simplify some code that is using vectors #

Patch Set 3 : code review 181080: simplify some code that is using vectors #

Created: 16 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -37 lines)			Patch
	M	src/pkg/go/parser/parser.go	View		12 chunks	+37 lines, -37 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gri

Hello agl (cc: golang-dev@googlegroups.com), I'd like you to review the following change.

16 years, 3 months ago (2009-12-28 20:12:07 UTC) #1

agl1

LGTM. It seems to me that this is 'cheating' a little as it only works ...

16 years, 3 months ago (2009-12-28 20:21:22 UTC) #2

gri

Perhaps , but if you consider vectors as slices for which we happen to have ...

16 years, 3 months ago (2009-12-28 20:27:35 UTC) #3

gri

16 years, 3 months ago (2009-12-28 20:27:45 UTC) #4

*** Submitted as http://code.google.com/p/go/source/detail?r=ebf4eacee078 ***

simplify some code that is using vectors

R=agl, agl1
CC=golang-dev
http://codereview.appspot.com/181080

Expand All Messages | Collapse All Messages