Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(70)

Issue 18100044: Fix gir annotations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years ago by fujiwara
Modified:
11 years ago
Reviewers:
shawn.p.huang, Peng
CC:
shawn.p.huang_gmail.com, fujiwara
Base URL:
git://github.com/ibus/ibus.git@master
Visibility:
Public.

Description

Fix gir annotations. TEST=g-ir-scanner@src

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated with the latest master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -164 lines) Patch
M engine/Makefile.am View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ibusattribute.h View 3 chunks +7 lines, -5 lines 0 comments Download
M src/ibusattrlist.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ibuscomponent.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ibusconfig.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/ibusconfigservice.h View 5 chunks +7 lines, -7 lines 0 comments Download
M src/ibusdebug.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ibusengine.h View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ibusenginedesc.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ibusenumtypes.h.template View 2 chunks +3 lines, -2 lines 0 comments Download
M src/ibuserror.h View 2 chunks +7 lines, -8 lines 0 comments Download
M src/ibusfactory.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/ibushotkey.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ibusinputcontext.c View 1 chunk +2 lines, -0 lines 0 comments Download
M src/ibuskeymap.h View 3 chunks +6 lines, -5 lines 0 comments Download
M src/ibuskeysyms-compat.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ibuskeyuni.c View 2 chunks +0 lines, -20 lines 0 comments Download
M src/ibuslookuptable.h View 2 chunks +9 lines, -6 lines 0 comments Download
M src/ibusobject.h View 4 chunks +6 lines, -5 lines 0 comments Download
M src/ibusobject.c View 2 chunks +2 lines, -9 lines 0 comments Download
M src/ibusobservedpath.h View 4 chunks +9 lines, -7 lines 0 comments Download
M src/ibuspanelservice.c View 24 chunks +24 lines, -0 lines 0 comments Download
M src/ibusproplist.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/ibusproxy.h View 2 chunks +11 lines, -7 lines 0 comments Download
M src/ibusserializable.h View 3 chunks +5 lines, -4 lines 0 comments Download
M src/ibusservice.h View 4 chunks +6 lines, -6 lines 0 comments Download
M src/ibusshare.h View 3 chunks +5 lines, -5 lines 0 comments Download
M src/ibustext.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/ibustypes.h View 1 chunk +5 lines, -3 lines 0 comments Download
M src/ibusutil.h View 3 chunks +6 lines, -6 lines 0 comments Download
M src/ibusversion.h.in View 2 chunks +4 lines, -2 lines 0 comments Download
M src/ibusxml.h View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 3
fujiwara
11 years ago (2013-11-01 07:24:14 UTC) #1
Peng
lgtm https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c File src/ibuskeyuni.c (left): https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c#oldcode872 src/ibuskeyuni.c:872: * is no corresponding character. Removed?
11 years ago (2013-11-01 15:29:37 UTC) #2
fujiwara
11 years ago (2013-11-05 09:15:21 UTC) #3
Message was sent while issue was closed.
https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c
File src/ibuskeyuni.c (left):

https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c#oldcode872
src/ibuskeyuni.c:872: *               is no corresponding character.
On 2013/11/01 15:29:38, Peng wrote:
> Removed?

Yes. The duplicated annotation exists in ibuskeys.h
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b