Issue 18100044: Fix gir annotations.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 18100044: Fix gir annotations. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by fujiwara

Modified:
10 years, 5 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com, fujiwara

Base URL:
git://github.com/ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Fix gir annotations. TEST=g-ir-scanner@src

Patch Set 2 : Updated with the latest master. #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+190 lines, -164 lines)			Patch
M	engine/Makefile.am	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ibusattribute.h	View	3 chunks	+7 lines, -5 lines	0 comments	Download
M	src/ibusattrlist.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ibuscomponent.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ibusconfig.h	View	4 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ibusconfigservice.h	View	5 chunks	+7 lines, -7 lines	0 comments	Download
M	src/ibusdebug.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ibusengine.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/ibusenginedesc.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ibusenumtypes.h.template	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/ibuserror.h	View	2 chunks	+7 lines, -8 lines	0 comments	Download
M	src/ibusfactory.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ibushotkey.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ibusinputcontext.c	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/ibuskeymap.h	View	3 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ibuskeysyms-compat.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ibuskeyuni.c	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	src/ibuslookuptable.h	View	2 chunks	+9 lines, -6 lines	0 comments	Download
M	src/ibusobject.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ibusobject.c	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	src/ibusobservedpath.h	View	4 chunks	+9 lines, -7 lines	0 comments	Download
M	src/ibuspanelservice.c	View	24 chunks	+24 lines, -0 lines	0 comments	Download
M	src/ibusproplist.h	View	2 chunks	+6 lines, -5 lines	0 comments	Download
M	src/ibusproxy.h	View	2 chunks	+11 lines, -7 lines	0 comments	Download
M	src/ibusserializable.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/ibusservice.h	View	4 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ibusshare.h	View	3 chunks	+5 lines, -5 lines	0 comments	Download
M	src/ibustext.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	src/ibustypes.h	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/ibusutil.h	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	src/ibusversion.h.in	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/ibusxml.h	View	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Peng

lgtm https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c File src/ibuskeyuni.c (left): https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c#oldcode872 src/ibuskeyuni.c:872: * is no corresponding character. Removed?

10 years, 5 months ago (2013-11-01 15:29:37 UTC) #2

fujiwara

10 years, 5 months ago (2013-11-05 09:15:21 UTC) #3

Message was sent while issue was closed.

https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c
File src/ibuskeyuni.c (left):

https://codereview.appspot.com/18100044/diff/1/src/ibuskeyuni.c#oldcode872
src/ibuskeyuni.c:872: *               is no corresponding character.
On 2013/11/01 15:29:38, Peng wrote:
> Removed?

Yes. The duplicated annotation exists in ibuskeys.h

Expand All Messages | Collapse All Messages