code review 180640043: runtime: use go generate for zcallback_windows.go

runtime: use go generate for zcallback_windows.go

[brainman, 2014-12-06 04:00:24]

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),

I'd like you to review this change to
https://go.googlecode.com/hg/

[bradfitz, 2014-12-06 04:28:59]

Let's just wait until we're all on git next week for non-1.4 stuff.


On Fri, Dec 5, 2014 at 8:00 PM, <alex.brainman@gmail.com> wrote:

> Reviewers: rsc,
>
> Message:
> Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com),
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> runtime: use go generate for zcallback_windows.go
>
> Please review this at https://codereview.appspot.com/180640043/
>
> Affected files (+24, -6 lines):
>   M src/runtime/wincallback.go
>   M src/runtime/zcallback_windows.go
>
>
> Index: src/runtime/wincallback.go
> ===================================================================
> --- a/src/runtime/wincallback.go
> +++ b/src/runtime/wincallback.go
> @@ -17,7 +17,7 @@
>
>  const maxCallback = 2000
>
> -func main() {
> +func genasm() {
>         var buf bytes.Buffer
>
>         buf.WriteString(`// generated by wincallback.go; run go generate
> @@ -41,3 +41,24 @@
>                 os.Exit(2)
>         }
>  }
> +
> +func gengo() {
> +       var buf bytes.Buffer
> +
> +       buf.WriteString(fmt.Sprintf(`// generated by wincallback.go; run
> go generate
> +
> +package runtime
> +
> +const cb_max = %d // maximum number of windows callbacks allowed
> +`, maxCallback))
> +       err := ioutil.WriteFile("zcallback_windows.go", buf.Bytes(), 0666)
> +       if err != nil {
> +               fmt.Fprintf(os.Stderr, "wincallback: %s\n", err)
> +               os.Exit(2)
> +       }
> +}
> +
> +func main() {
> +       genasm()
> +       gengo()
> +}
> Index: src/runtime/zcallback_windows.go
> ===================================================================
> rename from src/runtime/runtime2_windows.go
> rename to src/runtime/zcallback_windows.go
> --- a/src/runtime/runtime2_windows.go
> +++ b/src/runtime/zcallback_windows.go
> @@ -1,8 +1,5 @@
> -// Copyright 2009 The Go Authors. All rights reserved.
> -// Use of this source code is governed by a BSD-style
> -// license that can be found in the LICENSE file.
> +// generated by wincallback.go; run go generate
>
>  package runtime
>
> -// TODO(brainman): move generation of zsys_windows_*.s out from
> cmd/dist/buildruntime.c and into here
> -const cb_max = 2000 // maximum number of windows callbacks allowed (must
> be in sync with MAXWINCB from cmd/dist/buildruntime.c)
> +const cb_max = 2000 // maximum number of windows callbacks allowed
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

[rsc, 2014-12-06 04:54:18]

Yes, please wait (see mail I sent earlier subject:transition).

FWIW, the change earlier today was not just a cleanup. The reason to move
that one piece out of cmd/dist today was to make cmd/api work again in
dev.cc, so it could be enabled again, so dev.cc and dev.garbage could be
merged into default, so that we hit Git with everything on master to begin
with, so that we don't have to have 'dev branch' support working in
git-review from day 1.

Russ

[brainman, 2014-12-06 05:21:28]

On 2014/12/06 04:54:18, rsc wrote:
> Yes, please wait (see mail I sent earlier subject:transition).
> 

I will. Sorry I didn't realize that change was holding us up. I would have
implemented it long time ago.

Alex

[gobot, 2014-12-19 05:17:00]

R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/180640043 is best) in the description in your
new CL.

Thanks very much.